public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support
@ 2024-11-26 13:26 Stoiko Ivanov
  2025-04-10 11:46 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2024-11-26 13:26 UTC (permalink / raw)
  To: pbs-devel

ran into an issue when clicking on the ESP of a VM while trying
single-file restore. Enabling the single option fixed the issue, and
got the partition successfully mounted.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
changes v1->v2:
* only enabled the single needed option, and put it in the block where
  the remaining NLS options were set already (overlooked that on the
  first attempt) - Thanks @Fabian for the feedback!

As the issue seems to have been around for around one year - I don't
think we need to rush applying it (and can do so when upgrading to a
new kernel+ZFS version)

 src/config-base | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/config-base b/src/config-base
index 1581b09..edd95c1 100644
--- a/src/config-base
+++ b/src/config-base
@@ -102,6 +102,7 @@ CONFIG_SYSFS=y
 CONFIG_NLS=y
 CONFIG_NLS_UTF8=y
 CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_CODEPAGE_437=y
 CONFIG_MSDOS_PARTITION=y
 CONFIG_EFI_PARTITION=y
 CONFIG_FILE_LOCKING=y
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support
  2024-11-26 13:26 [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support Stoiko Ivanov
@ 2025-04-10 11:46 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-04-10 11:46 UTC (permalink / raw)
  To: pve-devel, pbs-devel, Stoiko Ivanov

On Tue, 26 Nov 2024 14:26:02 +0100, Stoiko Ivanov wrote:
> ran into an issue when clicking on the ESP of a VM while trying
> single-file restore. Enabling the single option fixed the issue, and
> got the partition successfully mounted.
> 
> 

Applied, thanks!

[1/1] kernel: enable codepage 437 for vfat support
      commit: baeebaa05826ebe9980009c8d09a8415976092a0


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-10 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-26 13:26 [pbs-devel] [PATCH v2] kernel: enable codepage 437 for vfat support Stoiko Ivanov
2025-04-10 11:46 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal