public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose'
@ 2025-04-10  8:51 Lukas Wagner
  2025-04-10  8:51 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message Lukas Wagner
  2025-04-10  9:40 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Lukas Wagner @ 2025-04-10  8:51 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/config/TokenView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/config/TokenView.js b/www/config/TokenView.js
index b107f7f1..1734b359 100644
--- a/www/config/TokenView.js
+++ b/www/config/TokenView.js
@@ -193,7 +193,7 @@ Ext.define('PBS.config.TokenView', {
 	    handler: 'regenerateToken',
 	    dangerous: true,
 	    confirmMsg: rec => Ext.String.format(
-		gettext("Regenerate the secret of the API token '{0}'? All current use-sites will loose access!"),
+		gettext("Regenerate the secret of the API token '{0}'? All current use-sites will lose access!"),
 		rec.data.tokenid,
 	    ),
 	},
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message
  2025-04-10  8:51 [pbs-devel] [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Lukas Wagner
@ 2025-04-10  8:51 ` Lukas Wagner
  2025-04-10  9:06   ` Maximiliano Sandoval
  2025-04-10  9:40 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Thomas Lamprecht
  1 sibling, 1 reply; 4+ messages in thread
From: Lukas Wagner @ 2025-04-10  8:51 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/config/TokenView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/config/TokenView.js b/www/config/TokenView.js
index 1734b359..23299542 100644
--- a/www/config/TokenView.js
+++ b/www/config/TokenView.js
@@ -193,7 +193,7 @@ Ext.define('PBS.config.TokenView', {
 	    handler: 'regenerateToken',
 	    dangerous: true,
 	    confirmMsg: rec => Ext.String.format(
-		gettext("Regenerate the secret of the API token '{0}'? All current use-sites will lose access!"),
+		gettext("Regenerate the secret of the API token '{0}'? All users of the previous token secret will lose access!"),
 		rec.data.tokenid,
 	    ),
 	},
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message
  2025-04-10  8:51 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message Lukas Wagner
@ 2025-04-10  9:06   ` Maximiliano Sandoval
  0 siblings, 0 replies; 4+ messages in thread
From: Maximiliano Sandoval @ 2025-04-10  9:06 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion


Lukas Wagner <l.wagner@proxmox.com> writes:

> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/config/TokenView.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/config/TokenView.js b/www/config/TokenView.js
> index 1734b359..23299542 100644
> --- a/www/config/TokenView.js
> +++ b/www/config/TokenView.js
> @@ -193,7 +193,7 @@ Ext.define('PBS.config.TokenView', {
>  	    handler: 'regenerateToken',
>  	    dangerous: true,
>  	    confirmMsg: rec => Ext.String.format(
> -		gettext("Regenerate the secret of the API token '{0}'? All current use-sites will lose access!"),
> +		gettext("Regenerate the secret of the API token '{0}'? All users of the previous token secret will lose access!"),
>  		rec.data.tokenid,
>  	    ),
>  	},

This is a string that I had troubles translating, the proposed version
would be a big improvement both for ease of translation and clarity.

Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose'
  2025-04-10  8:51 [pbs-devel] [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Lukas Wagner
  2025-04-10  8:51 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message Lukas Wagner
@ 2025-04-10  9:40 ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-04-10  9:40 UTC (permalink / raw)
  To: pbs-devel, Lukas Wagner

On Thu, 10 Apr 2025 10:51:23 +0200, Lukas Wagner wrote:
> 


Applied, thanks!

[1/2] ui: token view: fix typo in 'lose'
      commit: d400673641282590b6db5fce144ef5417b291493
[2/2] ui: token view: rephrase token regenerate dialog message
      commit: f9532a3a84693d8d89c26dbe28483edfe9b54d9a


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-04-10  9:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-10  8:51 [pbs-devel] [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Lukas Wagner
2025-04-10  8:51 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: token view: rephrase token regenerate dialog message Lukas Wagner
2025-04-10  9:06   ` Maximiliano Sandoval
2025-04-10  9:40 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: token view: fix typo in 'lose' Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal