public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v5 proxmox proxmox-backup 0/6] fix 4788: statically linked proxmox-backup-client
Date: Wed, 09 Apr 2025 15:32:24 +0200	[thread overview]
Message-ID: <1744201233.0ernvy6sow.astroid@yuna.none> (raw)
In-Reply-To: <20250409110520.170697-1-c.ebner@proxmox.com>

with some follow-ups/fix-ups folded in.

thanks!

On April 9, 2025 1:05 pm, Christian Ebner wrote:
> As discussed in issue #4788 [0], statically linking of the
> `proxmox-backup-client` still suffers from possible incompatible
> dependencies on the NSS module libraries, further described in
> [1].
> 
> This patch series provides the means to statically compile the client
> with a workaround for the NSS lib limitation by relying on
> `hickory-dns` [2], as suggested by Thomas.
> The hickory-resolver is used for name resolution with the statically
> compiled binary instead of the default `getaddrinfo` based
> `GaiResolver`.
> 
> Since hickory-resolver depends on `ipconfig` for Windows targets when
> the `system-config` feature is enabled (required to read nameservers
> from `/etc/resolv.conf`), also the dependency on `ipconfig` is
> required by cargo. To workaround this, a dummy crate is registered in
> the cargo registry.
> 
> Changes since version 4:
> - Incorporated additions and suggestions regarding debian packaging
> 
> Changes since version 3:
> - Added default type GaiResolver to HttpsConnector
> - Include patch to mention different name resolution behavior in docs
> 
> Changes since version 2:
> - Use packaged version for hickory-resolver
> - Drop unneeded `ipconfig` dependency workaround
> - Rebased onto current master
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4788
> [1] https://sourceware.org/glibc/wiki/FAQ#Even_statically_linked_programs_need_some_shared_libraries_which_is_not_acceptable_for_me.__What_can_I_do.3F
> [2] https://github.com/hickory-dns/hickory-dns
> 
> proxmox:
> 
> Christian Ebner (1):
>   http: client: make https connector generic over resolver
> 
>  proxmox-http/Cargo.toml              |  1 +
>  proxmox-http/src/client/connector.rs | 17 ++++++++++++-----
>  proxmox-http/src/client/simple.rs    |  3 ++-
>  3 files changed, 15 insertions(+), 6 deletions(-)
> 
> proxmox-backup:
> 
> Christian Ebner (5):
>   build: always set --target
>   fix: 4788: Makefile: target for statically linked client binary
>   buildsys: build and package statically linked client binary
>   client: http: Use custom resolver for statically linked binary
>   docs: mention different name resolution for statically linked binary
> 
>  Cargo.toml                                    |  1 +
>  Makefile                                      | 28 +++++--
>  debian/control                                |  8 ++
>  ...oxmox-backup-client-static.bash-completion |  1 +
>  debian/proxmox-backup-client-static.install   |  3 +
>  debian/rules                                  |  2 +
>  docs/backup-client.rst                        |  5 ++
>  pbs-client/Cargo.toml                         |  1 +
>  pbs-client/src/http_client.rs                 | 81 ++++++++++++++++++-
>  9 files changed, 121 insertions(+), 9 deletions(-)
>  create mode 100644 debian/proxmox-backup-client-static.bash-completion
>  create mode 100644 debian/proxmox-backup-client-static.install
> 
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2025-04-09 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09 11:05 [pbs-devel] " Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox 1/6] http: client: make https connector generic over resolver Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox-backup 2/6] build: always set --target Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox-backup 3/6] fix: 4788: Makefile: target for statically linked client binary Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox-backup 4/6] buildsys: build and package " Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox-backup 5/6] client: http: Use custom resolver for statically linked binary Christian Ebner
2025-04-09 11:05 ` [pbs-devel] [PATCH v5 proxmox-backup 6/6] docs: mention different name resolution " Christian Ebner
2025-04-09 13:32 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1744201233.0ernvy6sow.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal