From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH backup 1/2] examples: h2server: port to http2::Builder::new
Date: Mon, 17 Mar 2025 13:51:00 +0100 [thread overview]
Message-ID: <1742215855.pcy1z5n66a.astroid@yuna.none> (raw)
In-Reply-To: <20250314124517.342993-1-m.sandoval@proxmox.com>
On March 14, 2025 1:45 pm, Maximiliano Sandoval wrote:
> Fixes the deprecation warning while building this example.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> examples/h2server.rs | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/examples/h2server.rs b/examples/h2server.rs
> index 678640e8..6b286e78 100644
> --- a/examples/h2server.rs
> +++ b/examples/h2server.rs
> @@ -1,9 +1,24 @@
> +use std::future::Future;
> +
> use anyhow::Error;
> use futures::*;
> use hyper::{Body, Request, Response};
>
> use tokio::net::{TcpListener, TcpStream};
>
> +#[derive(Clone, Copy)]
> +struct H2Executor;
> +
> +impl<Fut> hyper::rt::Executor<Fut> for H2Executor
> +where
> + Fut: Future + Send + 'static,
> + Fut::Output: Send,
> +{
> + fn execute(&self, fut: Fut) {
> + tokio::spawn(fut);
> + }
> +}
> +
> fn main() -> Result<(), Error> {
> proxmox_async::runtime::main(run())
> }
> @@ -26,12 +41,11 @@ async fn run() -> Result<(), Error> {
> async fn handle_connection(socket: TcpStream) -> Result<(), Error> {
> socket.set_nodelay(true).unwrap();
>
> - let mut http = hyper::server::conn::Http::new();
> - http.http2_only(true);
> + let mut http = hyper::server::conn::http2::Builder::new(H2Executor);
> // increase window size: todo - find optiomal size
> let max_window_size = (1 << 31) - 2;
> - http.http2_initial_stream_window_size(max_window_size);
> - http.http2_initial_connection_window_size(max_window_size);
> + http.initial_stream_window_size(max_window_size);
> + http.initial_connection_window_size(max_window_size);
>
> let service = hyper::service::service_fn(|_req: Request<Body>| {
> println!("Got request");
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-03-17 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 12:45 [pbs-devel] " Maximiliano Sandoval
2025-03-14 12:45 ` [pbs-devel] [PATCH backup 2/2] examples: h2s-server: port to http2::builder::new Maximiliano Sandoval
2025-03-17 12:51 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1742215855.pcy1z5n66a.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal