From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5229: tape: remove max sequence number limit
Date: Mon, 12 Feb 2024 12:26:13 +0100 (CET) [thread overview]
Message-ID: <1741533780.1171.1707737173307@webmail.proxmox.com> (raw)
In-Reply-To: <20240212110656.1333514-1-d.csapak@proxmox.com>
> impl MediaSet {
> - pub const MEDIA_SET_MAX_SEQ_NR: u64 = 100;
> -
Not sure why you delete the whole definition? IMHO, it is always
nicer to define such constants outside of the code...
- Dietmar
prev parent reply other threads:[~2024-02-12 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:06 Dominik Csapak
2024-02-12 11:26 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1741533780.1171.1707737173307@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox