From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH backup 1/4] datastore: docs: turn uri into hyperlink
Date: Wed, 04 Dec 2024 14:42:38 +0100 [thread overview]
Message-ID: <1733319751.rsdr3ej5wv.astroid@yuna.none> (raw)
In-Reply-To: <20241203134139.399703-1-m.sandoval@proxmox.com>
thanks!
On December 3, 2024 2:41 pm, Maximiliano Sandoval wrote:
> Fixes the cargo doc lint:
>
> ```
> warning: this URL is not a hyperlink
> --> pbs-datastore/src/data_blob.rs:555:5
> |
> 555 | /// https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = note: bare URLs are not automatically turned into clickable links
> = note: `#[warn(rustdoc::bare_urls)]` on by default
> help: use an automatic link instead
> |
> 555 | /// <https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h>
> | + +
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Found more warnings when running
>
> cargo doc --workspace --all
>
>
> pbs-datastore/src/data_blob.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pbs-datastore/src/data_blob.rs b/pbs-datastore/src/data_blob.rs
> index 0fb4d44c..0c05c5a4 100644
> --- a/pbs-datastore/src/data_blob.rs
> +++ b/pbs-datastore/src/data_blob.rs
> @@ -552,7 +552,7 @@ impl<'a, 'b> DataChunkBuilder<'a, 'b> {
> /// Check if the error code returned by `zstd_safe::compress`, or anything else that does FFI calls
> /// into zstd code, was `70` 'Destination buffer is too small' by subtracting the error code from
> /// `0` (with underflow), see `ERR_getErrorCode` in
> -/// https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h
> +/// <https://github.com/facebook/zstd/blob/dev/lib/common/error_private.h>
> ///
> /// There is a test below to ensure we catch any change in the interface or internal value.
> fn zstd_error_is_target_too_small(err: usize) -> bool {
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-12-04 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 13:41 [pbs-devel] " Maximiliano Sandoval
2024-12-03 13:41 ` [pbs-devel] [PATCH backup 2/4] pxar: extract: docs: remove redundant explicit link Maximiliano Sandoval
2024-12-03 13:41 ` [pbs-devel] [PATCH backup 3/4] datastore: docs: escape <uuid> Maximiliano Sandoval
2024-12-03 13:41 ` [pbs-devel] [PATCH backup 4/4] auth: doc: Explicitly set namespace for UserInfomation Maximiliano Sandoval
2024-12-04 13:42 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733319751.rsdr3ej5wv.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox