From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api types: add missing conf to blob archive name mapping
Date: Tue, 26 Nov 2024 13:41:35 +0100 [thread overview]
Message-ID: <1732624756.2bm5wbhpr8.astroid@yuna.none> (raw)
In-Reply-To: <1d5d8a7b-f31c-4f1a-bc69-814e57455e3d@proxmox.com>
On November 26, 2024 1:35 pm, Thomas Lamprecht wrote:
> Am 26.11.24 um 13:24 schrieb Christian Ebner:
>> Commit addfae26 ("api types: introduce `BackupArchiveName` type")
>> introduced a dedicated archive name api type to add rust type
>> checking and bundle helpers to the api type. Since this, the backup
>> archive name to server archive name mapping is handled by its parser.
>
> This is mostly relevant for the client or? I.e., this has no impact on
> community implementations/experiments adding completely different archive
> types?
yes, this is just a UX shortcut that allows leaving out the .blob
extension for blob types used by our stack. if you use a custom blob
type, you need to specify the full name including .blob when passing the
name to the client.
the reason is that with a generic catch-all matching to blob, we'd take
away our ability to add new index types without breaking clients relying
on that magic.
i.e., if a client could do `restore ... my_custom_blob.foobar`, we can't
add a `foobar` index/archive type ourselves later on without breaking
that client.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-26 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 12:24 Christian Ebner
2024-11-26 12:32 ` [pbs-devel] applied: " Fabian Grünbichler
2024-11-26 12:35 ` [pbs-devel] " Thomas Lamprecht
2024-11-26 12:41 ` Fabian Grünbichler [this message]
2024-11-26 12:48 ` Christian Ebner
2024-11-26 12:52 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732624756.2bm5wbhpr8.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox