From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 5/5] ui: allow resetting unmounting maintenance
Date: Tue, 26 Nov 2024 13:11:14 +0100 [thread overview]
Message-ID: <1732622998.1oln17dk58.astroid@yuna.none> (raw)
In-Reply-To: <20241126114323.105838-6-h.laimer@proxmox.com>
Acked-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
but not applied in case somebody else wants to keep this away from the
UI for now ;)
On November 26, 2024 12:43 pm, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> optional, just added it in case we want it
>
> www/window/MaintenanceOptions.js | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/www/window/MaintenanceOptions.js b/www/window/MaintenanceOptions.js
> index 896d6a58e..8a88ba2b7 100644
> --- a/www/window/MaintenanceOptions.js
> +++ b/www/window/MaintenanceOptions.js
> @@ -89,12 +89,11 @@ Ext.define('PBS.window.MaintenanceOptions', {
> let unmounting = options['maintenance-type'] === 'unmount';
> let defaultType = options['maintenance-type'] === '__default__';
> if (unmounting) {
> - options['maintenance-type'] = '';
> + options['maintenance-type'] = gettext('Unmounting');
> }
>
> me.callParent([options]);
>
> - me.lookupReference('type-field').setDisabled(unmounting);
> me.lookupReference('message-field').setDisabled(unmounting || defaultType);
> },
> });
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-26 12:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 11:43 [pbs-devel] [PATCH proxmox-backup 0/5] removable datastore follow-up Hannes Laimer
2024-11-26 11:43 ` [pbs-devel] [PATCH proxmox-backup 1/5] api: mainatenance: allow setting of maintenance mode if 'unmounting' Hannes Laimer
2024-11-26 11:43 ` [pbs-devel] [PATCH proxmox-backup 2/5] api: add Sys.Modify on /system/disks as permission to endpoints handling removable datastores Hannes Laimer
2024-11-26 12:07 ` Fabian Grünbichler
2024-11-26 12:26 ` Thomas Lamprecht
2024-11-26 13:53 ` Hannes Laimer
2024-11-26 14:14 ` Fabian Grünbichler
2024-11-26 11:43 ` [pbs-devel] [PATCH proxmox-backup 3/5] api: types: add 'mount_status' to schema Hannes Laimer
2024-11-26 11:43 ` [pbs-devel] [PATCH proxmox-backup 4/5] docs: add information for removable datastores Hannes Laimer
2024-11-26 11:43 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: allow resetting unmounting maintenance Hannes Laimer
2024-11-26 12:11 ` Fabian Grünbichler [this message]
2024-11-26 15:35 ` [pbs-devel] applied: " Thomas Lamprecht
2024-11-26 12:09 ` [pbs-devel] partially applied: [PATCH proxmox-backup 0/5] removable datastore follow-up Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732622998.1oln17dk58.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox