From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v3 proxmox-backup 1/2] docs: add security implications of prune and change detection mode
Date: Mon, 25 Nov 2024 11:56:13 +0100 [thread overview]
Message-ID: <1732532163.ggb994v280.astroid@yuna.none> (raw)
In-Reply-To: <20241114151551.407971-1-c.ebner@proxmox.com>
thanks!
On November 14, 2024 4:15 pm, Christian Ebner wrote:
> Users should be made aware that the data stored in chunks outlives
> the backup snapshots on pruning and that backups created using the
> change-detection-mode set to metadata might reference chunks
> containing files which have vanished since the previous backup, but
> might still be accessible when access to the chunks raw data is
> possible (client or server side).
>
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 2:
> - s/Further/Moreover/ for second sentence starting with Further
> - fix formatting for metadata by using double backticks
> - Improve text flow based on suggestions
>
> docs/maintenance.rst | 30 ++++++++++++++++++++++++++++--
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
> diff --git a/docs/maintenance.rst b/docs/maintenance.rst
> index 4bb135e4e..601756246 100644
> --- a/docs/maintenance.rst
> +++ b/docs/maintenance.rst
> @@ -6,8 +6,34 @@ Maintenance Tasks
> Pruning
> -------
>
> -Prune lets you specify which backup snapshots you want to keep.
> -The following retention options are available:
> +Prune lets you specify which backup snapshots you want to keep, removing others.
> +When pruning a snapshot, only the snapshot metadata (manifest, indices, blobs,
> +log and notes) is removed. The chunks containing the actual backup data and
> +previously referenced by the pruned snapshot, have to be removed by a garbage
> +collection run.
> +
> +.. Caution:: Take into consideration that sensitive information stored in a
> + given data chunk will outlive pruned snapshots and remain present in the
> + datastore as long as referenced by at least one backup snapshot. Further,
> + *even* if no snapshot references a given chunk, it will remain present until
> + removed by the garbage collection.
> +
> + Moreover, file-level backups created using the change detection mode
> + ``metadata`` can reference backup chunks containing files which have vanished
> + since the previous backup. These files might still be accessible by reading
> + the chunks raw data (client or server side).
> +
> + To remove chunks containing sensitive data, prune any snapshot made while the
> + data was part of the backup input and run a garbage collection. Further, if
> + using file-based backups with change detection mode ``metadata``,
> + additionally prune all snapshots since the sensitive data was no longer part
> + of the backup input and run a garbage collection.
> +
> + The no longer referenced chunks will then be marked for deletion on the next
> + garbage collection run and removed by a subsequent run after the grace
> + period.
> +
> +The following retention options are available for pruning:
>
> ``keep-last <N>``
> Keep the last ``<N>`` backup snapshots.
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-25 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 15:15 [pbs-devel] " Christian Ebner
2024-11-14 15:15 ` [pbs-devel] [PATCH v3 proxmox-backup 2/2] docs: deduplicate background details for garbage collection Christian Ebner
2024-11-25 10:56 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732532163.ggb994v280.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox