Re: [pbs-devel] [PATCH proxmox-backup v12 04/26] maintenance: add 'Unmount' maintenance type

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On September 4, 2024 4:11 pm, Hannes Laimer wrote:
> From: Dietmar Maurer <dietmar@proxmox.com>
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>

so is this a patch from Dietmar or (partially) from you?

> ---
>  pbs-api-types/src/datastore.rs   | 3 +++
>  pbs-api-types/src/maintenance.rs | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 863ed317..d6e2f97e 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -404,6 +404,9 @@ impl DataStoreConfig {
>          match current_type {
>              Some(MaintenanceType::ReadOnly) => { /* always OK  */ }
>              Some(MaintenanceType::Offline) => { /* always OK  */ }
> +            Some(MaintenanceType::Unmount) => {
> +                bail!("datastore is being unmounted");
> +            }
>              Some(MaintenanceType::Delete) => {
>                  match new_type {
>                      Some(MaintenanceType::Delete) => { /* allow to delete a deleted storage */ }
> diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs
> index 1e3413dc..fd4d3416 100644
> --- a/pbs-api-types/src/maintenance.rs
> +++ b/pbs-api-types/src/maintenance.rs
> @@ -38,7 +38,6 @@ pub enum Operation {
>  /// Maintenance type.
>  pub enum MaintenanceType {
>      // TODO:
> -    //  - Add "unmounting" once we got pluggable datastores
>      //  - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate
>      //    operation, so that one can enable a mode where nothing new can be added but stuff can be
>      //    cleaned
> @@ -48,6 +47,8 @@ pub enum MaintenanceType {
>      Offline,
>      /// The datastore is being deleted.
>      Delete,
> +    /// The (removable) datastore is being unmounted.
> +    Unmount,
>  }
>  serde_plain::derive_display_from_serialize!(MaintenanceType);
>  serde_plain::derive_fromstr_from_deserialize!(MaintenanceType);
> @@ -94,6 +95,8 @@ impl MaintenanceMode {
>  
>          if let Some(Operation::Lookup) = operation {
>              return Ok(());
> +        } else if self.ty == MaintenanceType::Unmount {
> +            bail!("datastore is being unmounted");
>          } else if self.ty == MaintenanceType::Offline {
>              bail!("offline maintenance mode: {}", message);
>          } else if self.ty == MaintenanceType::ReadOnly {
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel