public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH vma-to-pbs v3 0/2] add support for notes and logs
Date: Thu, 11 Jul 2024 10:50:04 +0200	[thread overview]
Message-ID: <172068780438.109383.3815056544992095597@yuna.proxmox.com> (raw)
In-Reply-To: <20240710145732.142784-1-f.schauer@proxmox.com>

I still hope we manage to extract the backup client properly at some point..

Quoting Filip Schauer (2024-07-10 16:57:30)
> Changes since v2:
> * Split the create_pbs_backup_task argument change into its own commit
> * Create the HttpClient directly to avoid writing the password into an
>   environment variable
> * Put the client setup into its own helper function and call it from
>   backup_vma_to_pbs along with set_notes and upload_log
> 
> Changes since v1:
> * Set notes and upload log separately via a new connection to the API,
>   instead of hacking notes into the proxmox-backup-qemu C functions and
>   uploading the log as a config.
> 
> vma-to-pbs:
> 
> Filip Schauer (2):
>   pass args by reference to create_pbs_backup_task
>   add support for notes and logs
> 
>  Cargo.toml     |   8 +++
>  src/main.rs    |  16 ++++++
>  src/vma2pbs.rs | 133 +++++++++++++++++++++++++++++++++++++++++++++----
>  3 files changed, 147 insertions(+), 10 deletions(-)
> 
> 
> Summary over all repositories:
>   3 files changed, 147 insertions(+), 10 deletions(-)
> 
> -- 
> Generated by git-murpp 0.6.0
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2024-07-11  8:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 14:57 [pbs-devel] " Filip Schauer
2024-07-10 14:57 ` [pbs-devel] [PATCH vma-to-pbs v3 1/2] pass args by reference to create_pbs_backup_task Filip Schauer
2024-07-10 14:57 ` [pbs-devel] [PATCH vma-to-pbs v3 2/2] add support for notes and logs Filip Schauer
2024-07-11  8:50 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172068780438.109383.3815056544992095597@yuna.proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal