public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup-qemu/vma-to-pbs 0/2] add support for notes and logs
Date: Wed, 03 Jul 2024 15:06:24 +0200	[thread overview]
Message-ID: <1720011814.0592udjbmw.astroid@yuna.none> (raw)
In-Reply-To: <20240527130715.189131-1-f.schauer@proxmox.com>

On May 27, 2024 3:07 pm, Filip Schauer wrote:
> Allow the user of vma-to-pbs to specify a notes file and a log file to
> associate with the backup.
> 
> proxmox-backup-qemu:
> 
> Filip Schauer (1):
>   add support for notes

I am not sure this is really warranted, especially since we don't want
to keep using the proxmox-backup-qemu lib here in the long run anyway,
but switch to a (to-be-extracted) pure Rust client directly..

as a stop-gap measure, couldn't we just use `proxmox-backup-client` to
set the notes?

> 
>  src/backup.rs | 6 +++++-
>  src/lib.rs    | 9 +++++++++
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> 
> vma-to-pbs:
> 
> Filip Schauer (1):
>   add support for notes and logs

and the log as well, since that is not really handled correctly right
now anyway (the log is not a config file, there is a special command/API
endpoint for uploading the log).

> 
>  src/main.rs    | 16 +++++++++++++
>  src/vma2pbs.rs | 64 ++++++++++++++++++++++++++++++++++++++++++--------
>  2 files changed, 70 insertions(+), 10 deletions(-)
> 
> 
> Summary over all repositories:
>   4 files changed, 84 insertions(+), 11 deletions(-)
> 
> -- 
> Generated by git-murpp 0.6.0
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-07-03 13:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 13:07 Filip Schauer
2024-05-27 13:07 ` [pbs-devel] [PATCH backup-qemu 1/2] add support for notes Filip Schauer
2024-05-27 13:07 ` [pbs-devel] [PATCH vma-to-pbs 2/2] add support for notes and logs Filip Schauer
2024-07-03 13:06 ` Fabian Grünbichler [this message]
2024-07-03 13:28   ` [pbs-devel] [PATCH backup-qemu/vma-to-pbs 0/2] " Filip Schauer
2024-07-03 14:24     ` Fabian Grünbichler
2024-07-10  9:20       ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1720011814.0592udjbmw.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal