[pbs-devel] [PATCH proxmox-backup] build: fix `nocheck` build

[pbs-devel] [PATCH proxmox-backup] build: fix `nocheck` build

[Fabian Grünbichler]

pbs2to3 was missing from the list of to-be-compiled binaries, and thus was only
compiled as a side-effect of running `cargo test` (which is skipped when the
build is using the `nocheck` build profile).

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
the whole COMPILED_BINS handling seems a bit incomplete, should we also add
pbs2to3 and docgen/dump-catalog-shell-cli to it?

 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 03e938767..3e2341864 100644
--- a/Makefile
+++ b/Makefile
@@ -176,6 +176,7 @@ $(COMPILED_BINS) $(COMPILEDIR)/dump-catalog-shell-cli $(COMPILEDIR)/docgen: .do-
 	    --bin proxmox-restore-daemon \
 	    --package proxmox-backup \
 	    --bin docgen \
+	    --bin pbs2to3 \
 	    --bin proxmox-backup-api \
 	    --bin proxmox-backup-manager \
 	    --bin proxmox-backup-proxy \
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] build: fix `nocheck` build

[Fabian Grünbichler]

since I ran into this again..

On June 3, 2024 2:04 pm, Fabian Grünbichler wrote:
> pbs2to3 was missing from the list of to-be-compiled binaries, and thus was only
> compiled as a side-effect of running `cargo test` (which is skipped when the
> build is using the `nocheck` build profile).
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> the whole COMPILED_BINS handling seems a bit incomplete, should we also add
> pbs2to3 and docgen/dump-catalog-shell-cli to it?
> 
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 03e938767..3e2341864 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -176,6 +176,7 @@ $(COMPILED_BINS) $(COMPILEDIR)/dump-catalog-shell-cli $(COMPILEDIR)/docgen: .do-
>  	    --bin proxmox-restore-daemon \
>  	    --package proxmox-backup \
>  	    --bin docgen \
> +	    --bin pbs2to3 \
>  	    --bin proxmox-backup-api \
>  	    --bin proxmox-backup-manager \
>  	    --bin proxmox-backup-proxy \
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel