public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v5 1/4] proxmox-log: add tracing infrastructure
Date: Wed, 26 Jun 2024 09:55:53 +0200	[thread overview]
Message-ID: <1719388510.tvonuzfe6v.astroid@yuna.none> (raw)
In-Reply-To: <4bcf0824-a75c-40b7-8017-2a1ad690d579@proxmox.com>

On June 25, 2024 11:04 am, Lukas Wagner wrote:
> 
> 
> On  2024-06-25 10:44, Gabriel Goller wrote:
>> Thanks for the review!
>> 
>> On 24.06.2024 13:10, Lukas Wagner wrote:
>>> Just wondering, have you seen/checked out tracing-journald?
>>> Would that be interesting for us?
>>>
>>> https://docs.rs/tracing-journald/latest/tracing_journald/
>> 
>> I packaged it for debian some time ago. It basically does the same as
>> the current `syslog` lib and custom subscriber, so we should just be
>> able to drop it in. Don't know if that's too much for this series though :). Maybe as a follow-up? What do you think?
> 
> tracing-journald seems easy enough to use/set up, so IMHO you could include this in
> series.

FWIW, tracing-journald is now packaged on the devel repo (either for
a v6 or a follow-up using it).


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




  reply	other threads:[~2024-06-26  7:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 13:56 [pbs-devel] [PATCH proxmox{, -backup} v5 0/4] proxmox-log introduction Gabriel Goller
2024-06-13 13:56 ` [pbs-devel] [PATCH proxmox v5 1/4] proxmox-log: add tracing infrastructure Gabriel Goller
2024-06-24 11:10   ` Lukas Wagner
2024-06-25  8:44     ` Gabriel Goller
2024-06-25  9:04       ` Lukas Wagner
2024-06-26  7:55         ` Fabian Grünbichler [this message]
2024-06-13 13:56 ` [pbs-devel] [PATCH proxmox v5 2/4] enable tracing logger, remove task_log macros Gabriel Goller
2024-06-24 11:09   ` Lukas Wagner
2024-06-25  8:49     ` Gabriel Goller
2024-06-13 13:56 ` [pbs-devel] [PATCH proxmox-backup v5 3/4] switch from task_log! macro to tracing Gabriel Goller
2024-06-24 11:10   ` Lukas Wagner
2024-06-13 13:56 ` [pbs-devel] [PATCH proxmox-backup v5 4/4] api: " Gabriel Goller
2024-06-24 11:13 ` [pbs-devel] [PATCH proxmox{, -backup} v5 0/4] proxmox-log introduction Lukas Wagner
2024-06-26 13:10 ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1719388510.tvonuzfe6v.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal