public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v4 pxar proxmox-backup 0/3] fix fuse mount performance for split archives
Date: Mon, 17 Jun 2024 11:28:27 +0200	[thread overview]
Message-ID: <1718616499.mgt0kjmh6w.astroid@yuna.none> (raw)
In-Reply-To: <20240612131713.133353-1-c.ebner@proxmox.com>

thanks!

On June 12, 2024 3:17 pm, Christian Ebner wrote:
> Fuse mounts for split pxar archives currently greatly suffer from the
> consistency check between metadata and payload data archives, as
> these happen already during decoding of the payload reference entry
> in the metadata archive. By moving this check to the content reader
> instantiation, the performance can be improved significantly, as now
> the payload data chunks only need to be fetched and decoded when
> actually accessing the file payloads.
> 
> Changes since version 3:
> - fix missing adaption to tests for already applied patches
> - move ContentRange to accessor
> - move payload header check to FileContentsImpl new method, make it private
> - drop unsafe from `open_contents_at_range`
> 
> Changes since version 2:
> - Make helper and ContentRange pub(crate) only
> - Fix typo in commit message
> - Move incorrectly squashed cargo fmt patch into own patch
> 
> Changes since version 1:
> - Add previously missing check when accessing contents via the accessor
>   instead of the decoder.
> - Add missing context and refactor file entry extraction branch in pxar
>   extract according to suggestions
> 
> pxar:
> 
> Christian Ebner (2):
>   tests: adapt tests to decoder interface changes
>   accessor: adapt and restrict contents access
> 
>  src/accessor/aio.rs  | 16 ++++++-----
>  src/accessor/mod.rs  | 68 ++++++++++++++++++++++++++++++++------------
>  src/accessor/sync.rs | 16 ++++++-----
>  tests/compat.rs      |  1 +
>  tests/simple/fs.rs   |  2 +-
>  5 files changed, 70 insertions(+), 33 deletions(-)
> 
> proxmox-backup:
> 
> Christian Ebner (1):
>   client: pxar: fix fuse mount performance for split archives
> 
>  pbs-client/src/pxar/extract.rs | 62 ++++++++++++++++------------------
>  pbs-pxar-fuse/src/lib.rs       | 19 ++++++-----
>  src/api2/tape/restore.rs       |  2 +-
>  3 files changed, 41 insertions(+), 42 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2024-06-17  9:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 13:17 [pbs-devel] " Christian Ebner
2024-06-12 13:17 ` [pbs-devel] [PATCH v4 pxar 1/3] tests: adapt tests to decoder interface changes Christian Ebner
2024-06-12 13:17 ` [pbs-devel] [PATCH v4 pxar 2/3] accessor: adapt and restrict contents access Christian Ebner
2024-06-12 13:17 ` [pbs-devel] [PATCH v4 proxmox-backup 3/3] client: pxar: fix fuse mount performance for split archives Christian Ebner
2024-06-17  9:28 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718616499.mgt0kjmh6w.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal