From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] file-restore: list: improve pxar v2 performance
Date: Mon, 10 Jun 2024 11:53:27 +0200 [thread overview]
Message-ID: <1718013200.0wa1t4xajj.astroid@yuna.none> (raw)
In-Reply-To: <20240610083933.155146-1-c.ebner@proxmox.com>
On June 10, 2024 10:39 am, Christian Ebner wrote:
> Do not attach the payload reader for split pxar archives, as only the
> metadata has to be accessed for listing.
> This avoids that the decoder performs consistency checks with the
> payload stream, which require chunk download and decoding, making the
> listing unusable slow.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> proxmox-file-restore/src/main.rs | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs
> index a09873467..3dc2b3fd9 100644
> --- a/proxmox-file-restore/src/main.rs
> +++ b/proxmox-file-restore/src/main.rs
> @@ -170,7 +170,7 @@ async fn list_files(
> path = vec![b'/'];
> }
>
> - let (archive_name, payload_archive_name) =
> + let (archive_name, _payload_archive_name) =
> pbs_client::tools::get_pxar_archive_names(&file, &manifest)?;
>
> let (reader, archive_size) = get_remote_pxar_reader(
> @@ -181,19 +181,8 @@ async fn list_files(
> )
> .await?;
>
> - let reader = if let Some(payload_archive_name) = payload_archive_name {
> - let (payload_reader, payload_size) = get_remote_pxar_reader(
> - &payload_archive_name,
> - client,
> - &manifest,
> - crypt_config,
> - )
> - .await?;
> - pxar::PxarVariant::Split(reader, (payload_reader, payload_size))
> - } else {
> - pxar::PxarVariant::Unified(reader)
> - };
> -
> + // only care about the metadata, don't attach a payload reader
> + let reader = pxar::PxarVariant::Unified(reader);
> let accessor = Accessor::new(reader, archive_size).await?;
> let path = OsStr::from_bytes(&path);
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-10 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 8:39 [pbs-devel] " Christian Ebner
2024-06-10 9:53 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1718013200.0wa1t4xajj.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox