[pbs-devel] [PATCH proxmox-backup 1/2] client: backup spec: rename change detection mode default

[pbs-devel] [PATCH proxmox-backup 1/2] client: backup spec: rename change detection mode default

[Christian Ebner]

The currently default variant is named `Default`, which is not future
prove since the default might change in the future. So rename it to
`Legacy` instead.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-client/src/backup_specification.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/backup_specification.rs
index 66bf71965..cd9e34243 100644
--- a/pbs-client/src/backup_specification.rs
+++ b/pbs-client/src/backup_specification.rs
@@ -54,7 +54,7 @@ pub fn parse_backup_specification(value: &str) -> Result<BackupSpecification, Er
 pub enum BackupDetectionMode {
     /// Encode backup as self contained pxar archive
     #[default]
-    Default,
+    Legacy,
     /// Split backup mode, re-encode payload data
     Data,
     /// Compare metadata, reuse payload chunks if metadata unchanged
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox-backup 2/2] docs: add table listing possible change detection modes

[Christian Ebner]

Quick and concise listing of the available change detection modes for
reference.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 docs/backup-client.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/docs/backup-client.rst b/docs/backup-client.rst
index e541c5537..e56e0625b 100644
--- a/docs/backup-client.rst
+++ b/docs/backup-client.rst
@@ -320,6 +320,18 @@ the previous backup snapshot. Since the file might only partially re-use chunks
 to re-use or re-encode the currently cached entries is postponed to when enough
 information is available, comparing the possible padding to a threshold value.
 
+.. _client_change_detection_mode_table:
+
+============ ===================================================================
+Mode         Description
+============ ===================================================================
+``legacy``   (current default): Encode all files into a self contained pxar
+             archive.
+``data``     Encode all files into a split data and metadata pxar archive.
+``metadata`` Encode changed files, reuse unchanged from previous snapshot,
+             creating a split archive.
+============ ===================================================================
+
 The following shows an example for the client invocation with the `metadata`
 mode:
 
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup 1/2] client: backup spec: rename change detection mode default

[Fabian Grünbichler]

On June 7, 2024 3:12 pm, Christian Ebner wrote:
> The currently default variant is named `Default`, which is not future
> prove since the default might change in the future. So rename it to
> `Legacy` instead.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  pbs-client/src/backup_specification.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/backup_specification.rs
> index 66bf71965..cd9e34243 100644
> --- a/pbs-client/src/backup_specification.rs
> +++ b/pbs-client/src/backup_specification.rs
> @@ -54,7 +54,7 @@ pub fn parse_backup_specification(value: &str) -> Result<BackupSpecification, Er
>  pub enum BackupDetectionMode {
>      /// Encode backup as self contained pxar archive
>      #[default]
> -    Default,
> +    Legacy,
>      /// Split backup mode, re-encode payload data
>      Data,
>      /// Compare metadata, reuse payload chunks if metadata unchanged
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup 2/2] docs: add table listing possible change detection modes

[Fabian Grünbichler]

On June 7, 2024 3:12 pm, Christian Ebner wrote:
> Quick and concise listing of the available change detection modes for
> reference.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  docs/backup-client.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/docs/backup-client.rst b/docs/backup-client.rst
> index e541c5537..e56e0625b 100644
> --- a/docs/backup-client.rst
> +++ b/docs/backup-client.rst
> @@ -320,6 +320,18 @@ the previous backup snapshot. Since the file might only partially re-use chunks
>  to re-use or re-encode the currently cached entries is postponed to when enough
>  information is available, comparing the possible padding to a threshold value.
>  
> +.. _client_change_detection_mode_table:
> +
> +============ ===================================================================
> +Mode         Description
> +============ ===================================================================
> +``legacy``   (current default): Encode all files into a self contained pxar
> +             archive.
> +``data``     Encode all files into a split data and metadata pxar archive.
> +``metadata`` Encode changed files, reuse unchanged from previous snapshot,
> +             creating a split archive.
> +============ ===================================================================
> +
>  The following shows an example for the client invocation with the `metadata`
>  mode:
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel