Re: [pbs-devel] [PATCH v2 stable-2 pxar 1/1] format/decoder/accessor: backport pxar entry type `Version`

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On June 6, 2024 10:49 am, Christian Ebner wrote:
> On 6/6/24 10:21, Fabian Grünbichler wrote:
>> On June 5, 2024 5:41 pm, Christian Ebner wrote:
>>> Backports the pxar format entry type `Version` and the associated
>>> decoder methods. The format version entry is expected once as the
>>> first entry of the pxar archive, marked with a `PXAR_FORMAT_VERSION`
>>> header followed by the encoded version number for archives with
>>> format version 2 or higher.
>>> If not present, the default format version 1 is assumed as encoding
>>> format for the archive.
>>>
>>> The entry allows to early detect and bail if an incompatible archive
>>> version is encountered.
>>>
>>> The format version entry is not backwards compatible to pxar format
>>> version 1.
>>>
>>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> 
>>>       /// Symbolic links.
>>>       Symlink(format::Symlink),
>>>   
>>> diff --git a/tests/simple/fs.rs b/tests/simple/fs.rs
>>> index 9a89c4d..fd13e65 100644
>>> --- a/tests/simple/fs.rs
>>> +++ b/tests/simple/fs.rs
>>> @@ -229,6 +229,7 @@ impl Entry {
>>>                       })?))
>>>                   };
>>>               match item.kind() {
>>> +                PxarEntryKind::Version(_) => continue,
>> 
>> and as a result, this?
> 
> Same, given that I think this would not even require the patches on the 
> pbs side anymore, as the decoder/accessor will always fail anyway.

that was my conclusion as well (still needs a stable-2 rebuild with the
bumped stable-2 pxar of course).


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel