From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v2] sys: pass create options as reference
Date: Mon, 03 Jun 2024 14:21:30 +0200 [thread overview]
Message-ID: <1717417048.g0ke3iroho.astroid@yuna.none> (raw)
In-Reply-To: <1449403995.2265.1716986655072@webmail.proxmox.com>
On May 29, 2024 2:44 pm, Dietmar Maurer wrote:
>> I guess we could make a note for the next proxmox-sys bump we do for other reasons, but bumping half the world just for this seems a lot of work for little gain?
>
> This is just a cleanup, so it is not really required. But if we delay all cleanups, cleanup will take a long time (or will never happen ...)
we don't need to delay all cleanups (and I hope we don't :)), but for
those that contain breaking changes that cause a lot of churn, we need
to decide whether the churn *now* is worth it. and most of the time,
that decision will incorporate the benefits of the change (if it is
mostly cosmetic, then the scales will tip towards "let's put it on a
list of things to do when we have unavoidable/important breaking
changes").
improving our processes so we don't forget to incorporate such small
cleanups when the next good opportunity arrives would also be good
- because we definitely don't want to end up with them never happening!
> But yes, we want to split this crate anyways, so lets wait for that.
ack. issues like this are definitely an argument for crates with limited
scope and clear boundaries ;)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-03 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:55 Dietmar Maurer
2024-05-29 10:22 ` Fabian Grünbichler
2024-05-29 10:48 ` Dietmar Maurer
2024-05-29 12:44 ` Dietmar Maurer
2024-06-03 12:21 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1717417048.g0ke3iroho.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox