From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5439: disallow creation of datastore in root
Date: Thu, 16 May 2024 12:15:18 +0200 [thread overview]
Message-ID: <1715854228.w2ulz6r4kh.astroid@yuna.none> (raw)
In-Reply-To: <20240510095836.108283-1-g.goller@proxmox.com>
On May 10, 2024 11:58 am, Gabriel Goller wrote:
> Creating a datastore in root ('/') works, but afterwards gc fails (can't
> traverse all directories). It might be sensible to restrict this and
> disallow creation of datastores in the root directory.
if we do this, we should also forbid it on the frontend side ;)
I wonder whether we shouldn't handle this in a more generic fashion
though:
- disallow path being non-empty (ignoring .zfs ?) -> `/` is not allowed
by default
- unless a flag is set -> in case we forget to handle something, we need
an escape hatch
- if the flag is set, check whether .chunks already exists, and if it
does, do not recreate the chunk store
that way, we could also solve the "re-add datastore after re-install"
issue users are frequently facing..
obviously, even with that we can explicitly always forbid '/' (before or
after implementing such a mechanism), since that one is always wrong.
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> src/api2/config/datastore.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> index 6b742acb..671f07e9 100644
> --- a/src/api2/config/datastore.rs
> +++ b/src/api2/config/datastore.rs
> @@ -1,7 +1,7 @@
> use std::path::PathBuf;
>
> use ::serde::{Deserialize, Serialize};
> -use anyhow::Error;
> +use anyhow::{bail, Error};
> use hex::FromHex;
> use serde_json::Value;
>
> @@ -74,6 +74,10 @@ pub(crate) fn do_create_datastore(
> ) -> Result<(), Error> {
> let path: PathBuf = datastore.path.clone().into();
>
> + if path.parent().is_none() {
> + bail!("cannot create datastore in root path");
> + }
> +
> let tuning: DatastoreTuning = serde_json::from_value(
> DatastoreTuning::API_SCHEMA
> .parse_property_string(datastore.tuning.as_deref().unwrap_or(""))?,
> --
> 2.43.0
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-05-16 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 9:58 Gabriel Goller
2024-05-16 10:15 ` Fabian Grünbichler [this message]
2024-05-16 10:58 ` Gabriel Goller
2024-05-16 11:42 ` Fabian Grünbichler
2024-05-16 15:35 ` Gabriel Goller
2024-05-17 8:36 ` Fabian Grünbichler
2024-06-12 13:23 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715854228.w2ulz6r4kh.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox