public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	 Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox/proxmox-backup v3] tape: implement multithreaded read
Date: Thu, 20 Mar 2025 07:39:15 +0100 (CET)	[thread overview]
Message-ID: <1714326130.597.1742452755321@webmail.proxmox.com> (raw)
In-Reply-To: <47ae95f5-6ded-486b-8f03-a49c7d3ed585@proxmox.com>

This does not apply cleanly. I guess this needs a rebase...


> On 19.3.2025 15:12 CET Dominik Csapak <d.csapak@proxmox.com> wrote:
> 
>  
> On 2/21/25 16:06, Dominik Csapak wrote:
> > this is a replacement series for my previous patches[0]
> > 
> > I dropped the verification patches again, and moved the thread config to
> > the tape jobs/tape backup api. That way it's much nearer the actual
> > issue, and we don't run into problems with resource constraints, since
> > one job cannot run multiple times (if a user configures many jobs in
> > parallel, that must be deliberate then).
> > 
> > changes from v2:
> > * slight rewording of the commit message
> > * rebase on master (include pbs-api-types repo change)
> > * keep default to 1
> > * keep minimum of channel size 3
> > 
> > changes from v1:
> > * reordered code from verify,tape to tape,verify
> > * marked verify patches as rfc
> > * use a struct for saving the values in the datastore (as thomas
> >    suggested)
> > * introduces another verify patch to merge the chunk loading into the
> >    worker threads
> > 
> > 0: https://lore.proxmox.com/pbs-devel/20240507072955.364206-1-d.csapak@proxmox.com/
> > 
> 
> ping, would be nice to get feedback on this, since some users are asking for this on the forum
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-03-20  6:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 15:06 Dominik Csapak
2025-02-21 15:06 ` [pbs-devel] [PATCH proxmox v3 1/1] pbs api types: tape backup job: add worker threads option Dominik Csapak
2025-04-02 12:48   ` [pbs-devel] applied: " Thomas Lamprecht
2025-02-21 15:06 ` [pbs-devel] [PATCH proxmox-backup v3 1/1] tape: introduce a tape backup job worker thread option Dominik Csapak
2025-03-20 16:30   ` Thomas Lamprecht
2025-03-21  8:31     ` Dominik Csapak
2025-03-21 15:14     ` Laurențiu Leahu-Vlăducu
2025-04-02 14:48   ` [pbs-devel] applied: " Thomas Lamprecht
2025-03-19 14:12 ` [pbs-devel] [PATCH proxmox/proxmox-backup v3] tape: implement multithreaded read Dominik Csapak
2025-03-20  6:39   ` Dietmar Maurer [this message]
2025-03-20  8:03     ` Dietmar Maurer
2025-04-01 13:54 ` Bastian Mäuser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1714326130.597.1742452755321@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal