From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: fix layout reset
Date: Mon, 22 Apr 2024 13:57:55 +0200 [thread overview]
Message-ID: <1713787067.6ufbeb3c31.astroid@yuna.none> (raw)
In-Reply-To: <20240422110616.2091356-1-d.csapak@proxmox.com>
thanks!
On April 22, 2024 1:06 pm, Dominik Csapak wrote:
> we have to iterate over the keys of the state object here, not over the
> values. This meant one could not reset the layout from the settings
> window.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/window/Settings.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/window/Settings.js b/www/window/Settings.js
> index 763cefab..c785dd88 100644
> --- a/www/window/Settings.js
> +++ b/www/window/Settings.js
> @@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', {
> click: function() {
> let blacklist = ['login-username'];
> let sp = Ext.state.Manager.getProvider();
> - for (const state of Object.values(sp.state)) {
> + for (const state of Object.keys(sp.state)) {
> if (blacklist.indexOf(state) !== -1) {
> continue;
> }
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-04-22 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:06 [pbs-devel] " Dominik Csapak
2024-04-22 11:57 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1713787067.6ufbeb3c31.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox