[pbs-devel] [PATCH proxmox-backup 1/3] ui: sync view: rename column 'Max. Recursion' -> 'Max. Depth'

[pbs-devel] [PATCH proxmox-backup 1/3] ui: sync view: rename column 'Max. Recursion' -> 'Max. Depth'

[Lukas Wagner]

In the edit dialog we already use 'Max. Depth', so it makes sense
to use the same term in the overview.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/config/SyncView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index c6458a9e..0e8a0904 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -224,7 +224,7 @@ Ext.define('PBS.config.SyncJobView', {
 	    renderer: PBS.Utils.render_optional_namespace,
 	},
 	{
-	    header: gettext('Max. Recursion'),
+	    header: gettext('Max. Depth'),
 	    dataIndex: 'max-depth',
 	    width: 10,
 	    sortable: true,
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox-backup 2/3] ui: sync view: add 'max-depth' to model

[Lukas Wagner]

Otherwise, the sync job overview does no refresh if 'max-depth' is
changed in the edit window.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/config/SyncView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 0e8a0904..44f1b149 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -3,7 +3,7 @@ Ext.define('pbs-sync-jobs-status', {
     fields: [
 	'id', 'owner', 'remote', 'remote-store', 'remote-ns', 'store', 'ns',
 	'schedule', 'group-filter', 'next-run', 'last-run-upid', 'last-run-state',
-	'last-run-endtime', 'transfer-last',
+	'last-run-endtime', 'transfer-last', 'max-depth',
 	{
 	    name: 'duration',
 	    calculate: function(data) {
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox-backup 3/3] ui: sync view: increase default width of 'Max. Depth' column

[Lukas Wagner]

Before, the column was so small that it was practically invisible.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/config/SyncView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 44f1b149..4669a23e 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -226,7 +226,7 @@ Ext.define('PBS.config.SyncJobView', {
 	{
 	    header: gettext('Max. Depth'),
 	    dataIndex: 'max-depth',
-	    width: 10,
+	    width: 100,
 	    sortable: true,
 	},
 	{
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied-series: [PATCH proxmox-backup 1/3] ui: sync view: rename column 'Max. Recursion' -> 'Max. Depth'

[Fabian Grünbichler]

thanks!

On April 18, 2024 2:01 pm, Lukas Wagner wrote:
> In the edit dialog we already use 'Max. Depth', so it makes sense
> to use the same term in the overview.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/config/SyncView.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/config/SyncView.js b/www/config/SyncView.js
> index c6458a9e..0e8a0904 100644
> --- a/www/config/SyncView.js
> +++ b/www/config/SyncView.js
> @@ -224,7 +224,7 @@ Ext.define('PBS.config.SyncJobView', {
>  	    renderer: PBS.Utils.render_optional_namespace,
>  	},
>  	{
> -	    header: gettext('Max. Recursion'),
> +	    header: gettext('Max. Depth'),
>  	    dataIndex: 'max-depth',
>  	    width: 10,
>  	    sortable: true,
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel