From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-offline-mirror v2 0/3] improve pom multi-key handling
Date: Tue, 09 Jan 2024 09:11:16 +0100 [thread overview]
Message-ID: <1704787813.92t0pk0mbb.astroid@yuna.none> (raw)
In-Reply-To: <20231129145116.202049-1-s.sterz@proxmox.com>
FWIW, this got applied back in December by Thomas :)
On November 29, 2023 3:51 pm, Stefan Sterz wrote:
> this patch series intends to improve the user experience when a user
> adds multiple keys to one mirror and wants to use one medium to activate
> multiple products. the first commit removes the `ProductType` trait that
> has been moved to `proxmox-subscription` from pom. the second commit
> handles media with muliple keys for muliple products more gracefully in
> proxmox-offline-mirror-helper. it only tries to activate subscriptions
> that have a matching server id. the finally commit just adds some
> rustfmt clean ups.
>
> changes since v1 @ (thanks to Fabian Grünbichler):
>
> - moved to a hash map based approach when automatically selecting all
> applicable keys for the current system
>
>
> Stefan Sterz (3):
> type: move `ProductType` enum to `proxmox-subscription`
> helper: improve handling of multiple keys when activating them
> offline mirror binary: rustfmt clean up
>
> src/bin/proxmox-offline-mirror-helper.rs | 101 ++++++++++--------
> src/bin/proxmox-offline-mirror.rs | 15 ++-
> src/bin/proxmox_offline_mirror_cmds/medium.rs | 4 +-
> .../subscription.rs | 4 +-
> src/config.rs | 4 +-
> src/subscription.rs | 4 +-
> src/types.rs | 44 +-------
> 7 files changed, 75 insertions(+), 101 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
prev parent reply other threads:[~2024-01-09 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:51 [pbs-devel] " Stefan Sterz
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 1/3] type: move `ProductType` enum to `proxmox-subscription` Stefan Sterz
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 2/3] helper: improve handling of multiple keys when activating them Stefan Sterz
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 3/3] offline mirror binary: rustfmt clean up Stefan Sterz
2024-01-09 8:11 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1704787813.92t0pk0mbb.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox