From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] email_notifications: make html template more valid
Date: Wed, 30 Nov 2022 15:26:11 +0100 [thread overview]
Message-ID: <16d7b3cb-7887-58c9-6514-9fc18400a78e@proxmox.com> (raw)
In-Reply-To: <20221129164019.1193392-1-s.sterz@proxmox.com>
some thoughts:
i don't think 'more valid' is possible, either the markup is valid or not
On 11/29/22 17:40, Stefan Sterz wrote:
> some webmail interfaces may behave unexpectedly if the html is
> invalid. thus, close tags and declare a language.
which webmail interfaces? and according to whom is the old invalid and the new valid?
i checked the html spec of the whatwg[0] and it seems to me that
empty tags ('head' too) can be omitted
also the 'lang' attribute is only recommended, not required
the correct closing of the tags good though
0: https://html.spec.whatwg.org/multipage/semantics.html
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> src/server/email_notifications.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs
> index b3298cf9..378e805e 100644
> --- a/src/server/email_notifications.rs
> +++ b/src/server/email_notifications.rs
> @@ -294,7 +294,7 @@ fn send_job_status_mail(email: &str, subject: &str, text: &str) -> Result<(), Er
> // Note: OX has serious problems displaying text mails,
> // so we include html as well
> let html = format!(
> - "<html><body><pre>\n{}\n<pre>",
> + "<html lang=\"en\"><head></head><body><pre>\n{}\n</pre></body></html>",
> handlebars::html_escape(text)
> );
>
next prev parent reply other threads:[~2022-11-30 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 16:40 Stefan Sterz
2022-11-30 14:26 ` Dominik Csapak [this message]
2022-11-30 15:02 ` Stefan Sterz
2022-11-30 15:14 ` Dominik Csapak
2022-11-30 15:19 ` Stefan Sterz
2022-11-30 16:09 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d7b3cb-7887-58c9-6514-9fc18400a78e@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox