From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4380: check permissions before entering directory
Date: Fri, 4 Aug 2023 17:49:47 +0200 [thread overview]
Message-ID: <169cbd9f-3fbf-48eb-bac0-eb30b6164bb2@proxmox.com> (raw)
In-Reply-To: <20230804100225.95770-1-g.goller@proxmox.com>
just some higher-level process review:
please use a v2 tag if it's the second version, both git format-patch and
git send-email support adding that conveniently using -v2 (or -v3 and so
one if a later revision).
Am 04/08/2023 um 12:02 schrieb Gabriel Goller:
> When creating a backup, we now check if we have the correct permissions
> (r,x) before entering a directory. This is mainly to prevent stat() from
> failing with EACCESS errors. We also check if the directory contains
> non-excluded files and warn the user.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
please add a series changelog here, i.e., outside of what gets added to git
but easily discoverable. E.g., like:
changes v1:
- ...
See https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patches
and btw., as I observed it in a reply to Fiona in the v1 of this fix: please
ensure you use "reply all" when replying, so that the mailing list stays
included.
next prev parent reply other threads:[~2023-08-04 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 10:02 Gabriel Goller
2023-08-04 15:49 ` Thomas Lamprecht [this message]
2023-08-08 10:25 ` Wolfgang Bumiller
2023-08-10 7:20 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169cbd9f-3fbf-48eb-bac0-eb30b6164bb2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox