public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/4] pull/verify unified progress
Date: Tue, 1 Dec 2020 06:40:59 +0100 (CET)	[thread overview]
Message-ID: <1695309782.376.1606801260162@webmail.proxmox.com> (raw)
In-Reply-To: <20201130152721.666511-1-f.gruenbichler@proxmox.com>

applied, with some cleanups on top:

- removed unnecessary clone
- moved code into extra file: src/backup/store_progress.rs

> On 11/30/2020 4:27 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>  
> this series factors out and reuses the progress calculcation used by
> sync/pull for verification tasks, since the progress characteristics are
> rather similar:
> - we often skip big parts of groups (already synced/recently verified)
> - adding more snapshots within a group is usually fast (because of
>   deduplication/chunk reuse)
> 
> Fabian Grünbichler (4):
>   remove BackupGroup::list_groups
>   pull: factor out interpolated progress
>   progress: add format variants
>   verify: use same progress as pull
> 
>  src/api2/admin/datastore.rs |  4 +--
>  src/backup/backup_info.rs   | 14 --------
>  src/backup/datastore.rs     | 65 +++++++++++++++++++++++++++++++++++++
>  src/backup/verify.rs        | 61 +++++++++++++++-------------------
>  src/client/pull.rs          | 29 +++++++----------
>  src/server/prune_job.rs     |  4 +--
>  6 files changed, 108 insertions(+), 69 deletions(-)
> 
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




      parent reply	other threads:[~2020-12-01  5:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 15:27 [pbs-devel] " Fabian Grünbichler
2020-11-30 15:27 ` [pbs-devel] [PATCH proxmox-backup 1/4] remove BackupGroup::list_groups Fabian Grünbichler
2020-11-30 15:27 ` [pbs-devel] [PATCH proxmox-backup 2/4] pull: factor out interpolated progress Fabian Grünbichler
2020-12-01  5:21   ` Dietmar Maurer
2020-11-30 15:27 ` [pbs-devel] [PATCH proxmox-backup 3/4] progress: add format variants Fabian Grünbichler
2020-11-30 15:27 ` [pbs-devel] [PATCH proxmox-backup 4/4] verify: use same progress as pull Fabian Grünbichler
2020-12-01  5:40 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1695309782.376.1606801260162@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal