From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: sync job: add transfer-last parameter
Date: Mon, 17 Apr 2023 11:23:38 +0200 [thread overview]
Message-ID: <1681723228.1bz7zmrnt6.astroid@yuna.none> (raw)
In-Reply-To: <20230413154156.2304040-3-s.hanreich@proxmox.com>
works as expected, but looks a bit "jumpy" below the Ratelimit (since
that has the Unit at the end). maybe it could be re-ordered, or even
moved to the advanced section (until we have more snapshot filter
options, at which point we might move it to a "Snapshot Filter" tab?).
On April 13, 2023 5:41 pm, Stefan Hanreich wrote:
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> www/config/SyncView.js | 9 ++++++++-
> www/window/SyncJobEdit.js | 13 +++++++++++++
> 2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/www/config/SyncView.js b/www/config/SyncView.js
> index a90e9a70..bf9072cb 100644
> --- a/www/config/SyncView.js
> +++ b/www/config/SyncView.js
> @@ -3,7 +3,7 @@ Ext.define('pbs-sync-jobs-status', {
> fields: [
> 'id', 'owner', 'remote', 'remote-store', 'remote-ns', 'store', 'ns',
> 'schedule', 'group-filter', 'next-run', 'last-run-upid', 'last-run-state',
> - 'last-run-endtime',
> + 'last-run-endtime', 'transfer-last',
> {
> name: 'duration',
> calculate: function(data) {
> @@ -241,6 +241,13 @@ Ext.define('PBS.config.SyncJobView', {
> renderer: v => v ? Ext.String.htmlEncode(v) : gettext('All'),
> width: 80,
> },
> + {
> + header: gettext('Transfer Last'),
> + dataIndex: 'transfer-last',
> + flex: 1,
> + sortable: true,
> + hidden: true,
> + },
> {
> header: gettext('Schedule'),
> dataIndex: 'schedule',
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 948ad5da..64447ebc 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -131,6 +131,19 @@ Ext.define('PBS.window.SyncJobEdit', {
> submitAutoScaledSizeUnit: true,
> // NOTE: handle deleteEmpty in onGetValues due to bandwidth field having a cbind too
> },
> + {
> + fieldLabel: gettext('Transfer Last'),
> + xtype: 'pbsPruneKeepInput',
> + name: 'transfer-last',
> + emptyText: gettext('all'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('The maximum amount of snapshots to be transferred (per group)'),
> + },
> + cbind: {
> + deleteEmpty: '{!isCreate}',
> + },
> + },
> ],
>
> column2: [
> --
> 2.30.2
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
next prev parent reply other threads:[~2023-04-17 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 15:41 [pbs-devel] [PATCH-SERIES proxmox-backup v3 0/3] add transfer-last parameter to pull/sync job Stefan Hanreich
2023-04-13 15:41 ` [pbs-devel] [PATCH proxmox-backup v3 1/3] partial fix #3701: sync job: pull: add transfer-last parameter Stefan Hanreich
2023-04-17 8:56 ` Fabian Grünbichler
2023-04-13 15:41 ` [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: sync job: " Stefan Hanreich
2023-04-17 9:23 ` Fabian Grünbichler [this message]
2023-04-13 15:41 ` [pbs-devel] [PATCH proxmox-backup v3 3/3] sync job: pull: improve log output Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1681723228.1bz7zmrnt6.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox