public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: prune job edit: fix disabling jobs
Date: Mon, 14 Nov 2022 14:26:58 +0100	[thread overview]
Message-ID: <1668432340.zxcajjjalx.astroid@yuna.none> (raw)
In-Reply-To: <4ec96660-fe71-85d4-0a04-f3ea9de5f945@proxmox.com>

On November 14, 2022 11:54 am, Dominik Csapak wrote:
> IMO good, but do we really drop unrecognized parameters in the api?
> is that intentional? (iow. in pve it would have triggered an api exception
> since that parameter does not exist)

yes, if it's an AllOf Schema (which everything containing a flattened type is).
for regular ObjectSchema-s, AdditionalProperties like in PVE is configurable.




  reply	other threads:[~2022-11-14 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  9:42 Fiona Ebner
2022-11-14 10:54 ` Dominik Csapak
2022-11-14 13:26   ` Fabian Grünbichler [this message]
2022-11-14 14:01     ` Dominik Csapak
2022-11-15 14:29 ` Thomas Lamprecht
2022-11-16  9:41   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1668432340.zxcajjjalx.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal