[pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index

[pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index

[Stefan Reiter]

This is not a fatal condition, it just means that we cannot do
incremental backups client-side. This can happen if a new disk was added
the a VM since the last backup for example.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 src/commands.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/commands.rs b/src/commands.rs
index 9c21702..6f26324 100644
--- a/src/commands.rs
+++ b/src/commands.rs
@@ -114,7 +114,11 @@ pub(crate) async fn register_image(
 
     let index = match manifest {
         Some(manifest) => {
-            Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?)
+            match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await {
+                Ok(index) => Some(index),
+                // not having a previous index is not fatal, so ignore errors
+                Err(_) => None
+            }
         },
         None => None
     };
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup-qemu] ignore missing or bad previous index

[Dietmar Maurer]

applied, thanks!

> On 07/09/2020 2:12 PM Stefan Reiter <s.reiter@proxmox.com> wrote:
> 
>  
> This is not a fatal condition, it just means that we cannot do
> incremental backups client-side. This can happen if a new disk was added
> the a VM since the last backup for example.
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  src/commands.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/commands.rs b/src/commands.rs
> index 9c21702..6f26324 100644
> --- a/src/commands.rs
> +++ b/src/commands.rs
> @@ -114,7 +114,11 @@ pub(crate) async fn register_image(
>  
>      let index = match manifest {
>          Some(manifest) => {
> -            Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?)
> +            match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await {
> +                Ok(index) => Some(index),
> +                // not having a previous index is not fatal, so ignore errors
> +                Err(_) => None
> +            }
>          },
>          None => None
>      };
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel