From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup-qemu] ignore missing or bad previous index
Date: Thu, 9 Jul 2020 14:22:27 +0200 (CEST) [thread overview]
Message-ID: <1652249703.373.1594297348205@webmail.proxmox.com> (raw)
In-Reply-To: <20200709121242.26143-1-s.reiter@proxmox.com>
applied, thanks!
> On 07/09/2020 2:12 PM Stefan Reiter <s.reiter@proxmox.com> wrote:
>
>
> This is not a fatal condition, it just means that we cannot do
> incremental backups client-side. This can happen if a new disk was added
> the a VM since the last backup for example.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> src/commands.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/commands.rs b/src/commands.rs
> index 9c21702..6f26324 100644
> --- a/src/commands.rs
> +++ b/src/commands.rs
> @@ -114,7 +114,11 @@ pub(crate) async fn register_image(
>
> let index = match manifest {
> Some(manifest) => {
> - Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?)
> + match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await {
> + Ok(index) => Some(index),
> + // not having a previous index is not fatal, so ignore errors
> + Err(_) => None
> + }
> },
> None => None
> };
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2020-07-09 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 12:12 [pbs-devel] " Stefan Reiter
2020-07-09 12:22 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1652249703.373.1594297348205@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox