public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Roland Sturm <r.sturm@cibex.net>
Subject: Re: [pbs-devel] PBS File Retore for NTFS with deduplication enabled leads to corrupted files
Date: Wed, 27 Apr 2022 09:35:14 +0200	[thread overview]
Message-ID: <1651044569.oo1skrc0qp.astroid@nora.none> (raw)
In-Reply-To: <360557907.5748.1651033823899@webmail.proxmox.com>

On April 27, 2022 6:30 am, Dietmar Maurer wrote:
>> Think he would like to restore files from a windows Server (like a fileserver) with "Windows dedup" enabled on a volume.
>> Win Dedup works with chunk-files in "System Volume Information" Folder and metadatafiles to the "chunk-data".
>> 
>> We also use Win Dedup on File Servers
> 
> And you can reproduce the problem?
> 

see (German) https://forum.proxmox.com/threads/file-restore-dateien-defekt.108257

we could see whether ntfs-3g works better, but I am afraid from what I 
read in their issues they are playing a bit of cat and mouse with 
changes on the windows side, and the feature seems to not be backwards 
compatible in the windows world either, so chances are it will work 
better the older the VM's version of windows is.

alternatively, we could try to detect deduplicated files in the 
file-restore VM (based on some metadata?) and hard-fail the restore 
instead of returning valid-looking garbage.

users do report success with mapping + attaching the disk to an existing 
(version-matching) windows VM for manual file-restoring, so we could 
also think whether it's possible to streamline this approach somehow 
("attach disk RO from backup" on the PVE side?), since it's a lot more 
flexible for other use cases as well (e.g., encrypted disks inside the 
VM, storage management or FS we don't support in our file-restore VM, 
FS features that are not available in our file-restore VM kernel (yet or 
anymore ;)), ..). obviously an advanced use case, and for simple cases 
the existing file-restore approach is far nicer UX-wise.




  reply	other threads:[~2022-04-27  7:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  4:30 Dietmar Maurer
2022-04-27  7:35 ` Fabian Grünbichler [this message]
2022-04-27 12:16   ` Thomas Lamprecht
  -- strict thread matches above, loose matches on Subject: below --
2022-04-22 10:04 Dietmar Maurer
2022-04-22 10:54 ` Roland Sturm
2022-04-19  9:11 Daniel Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1651044569.oo1skrc0qp.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=r.sturm@cibex.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal