From: Dietmar Maurer <dietmar@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] api2/config/tape_backup_job: fix duplicate id parameter
Date: Tue, 23 Feb 2021 20:27:51 +0100 (CET) [thread overview]
Message-ID: <1644937938.10.1614108472151@webmail.proxmox.com> (raw)
In-Reply-To: <16b17f26-ec37-fd9f-004d-2fd146a4d900@proxmox.com>
Will fix this tomorrow - we need to set the #[fixed] attribute for id
> On 02/23/2021 6:00 PM Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
>
>
> On 23.02.21 17:26, Dietmar Maurer wrote:
> > applied
>
> did you read that part:
>
> On 23.02.21 15:54, Dominik Csapak wrote:
> > i am *really* not sure if this is the correct way @Wolfgang, is
> > there another wayt to selectively use the struct members for the
> > Updater?
>
>
> This makes the ID optional in the schema, which is weird for an API call
> with {id} in its url (which means that without ID this can never be reached).
>
> So not really an ideal fix, IMO, as the API schema gets basically wrong and
> possible confusing when suggesting this non-optional parameter is optional...
next prev parent reply other threads:[~2021-02-23 19:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:54 [pbs-devel] " Dominik Csapak
2021-02-23 16:26 ` [pbs-devel] applied: " Dietmar Maurer
2021-02-23 17:00 ` Thomas Lamprecht
2021-02-23 19:27 ` Dietmar Maurer [this message]
2021-02-24 6:13 ` Dietmar Maurer
2021-02-24 7:28 ` Dietmar Maurer
2021-02-24 8:35 ` Wolfgang Bumiller
2021-02-24 8:42 ` Dietmar Maurer
2021-02-24 9:02 ` Wolfgang Bumiller
2021-02-24 9:47 ` Dietmar Maurer
2021-02-25 8:53 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644937938.10.1614108472151@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox