From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup rebase 01/15] start new pbs-server workspace
Date: Mon, 20 Sep 2021 14:03:19 +0200 [thread overview]
Message-ID: <1632134258.i0mkw8z4ep.astroid@nora.none> (raw)
In-Reply-To: <20210920091340.3251578-1-dietmar@proxmox.com>
gave the whole series a quick go-over, looks okay to me and nothing in
the build output looks off. the proxmox-restore-daemon actually lost a
dependency thanks to the move (libstdc++), and relaxed its libc version
requirement (2.28 -> 2.18) :)
sent a little bit of code duplication/missing features I noticed
separately on the affected patches.
On September 20, 2021 11:13 am, Dietmar Maurer wrote:
> ---
> Cargo.toml | 2 ++
> Makefile | 1 +
> pbs-server/Cargo.toml | 9 +++++++++
> pbs-server/src/lib.rs | 0
> 4 files changed, 12 insertions(+)
> create mode 100644 pbs-server/Cargo.toml
> create mode 100644 pbs-server/src/lib.rs
>
> diff --git a/Cargo.toml b/Cargo.toml
> index 72d786c9..58abf7c6 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -26,6 +26,7 @@ members = [
> "pbs-datastore",
> "pbs-fuse-loop",
> "pbs-runtime",
> + "pbs-server",
> "pbs-systemd",
> "pbs-tape",
> "pbs-tools",
> @@ -107,6 +108,7 @@ pbs-client = { path = "pbs-client" }
> pbs-config = { path = "pbs-config" }
> pbs-datastore = { path = "pbs-datastore" }
> pbs-runtime = { path = "pbs-runtime" }
> +pbs-server = { path = "pbs-server" }
> pbs-systemd = { path = "pbs-systemd" }
> pbs-tools = { path = "pbs-tools" }
> pbs-tape = { path = "pbs-tape" }
> diff --git a/Makefile b/Makefile
> index e6c85a2e..050218ba 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -39,6 +39,7 @@ SUBCRATES := \
> pbs-datastore \
> pbs-fuse-loop \
> pbs-runtime \
> + pbs-server \
> pbs-systemd \
> pbs-tape \
> pbs-tools \
> diff --git a/pbs-server/Cargo.toml b/pbs-server/Cargo.toml
> new file mode 100644
> index 00000000..e933c1e6
> --- /dev/null
> +++ b/pbs-server/Cargo.toml
> @@ -0,0 +1,9 @@
> +[package]
> +name = "pbs-server"
> +version = "0.1.0"
> +authors = ["Proxmox Support Team <support@proxmox.com>"]
> +edition = "2018"
> +description = "REST server implementation"
> +
> +[dependencies]
> +anyhow = "1.0"
> diff --git a/pbs-server/src/lib.rs b/pbs-server/src/lib.rs
> new file mode 100644
> index 00000000..e69de29b
> --
> 2.30.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
prev parent reply other threads:[~2021-09-20 12:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 9:13 Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 02/15] move ApiConfig, FileLogger and CommandoSocket to " Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 03/15] move src/tools/daemon.rs " Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 04/15] move src/server/environment.rs to pbs-server crate Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 05/15] move src/server/formatter.rs " Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 06/15] move src/tools/compression.rs " Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 07/15] move normalize_uri_path and extract_cookie " Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 08/15] rest server: simplify get_index() method signature Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 09/15] make get_index and ApiConfig property (callback) Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 10/15] rest server: return UserInformation from ApiAuth::check_auth Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 11/15] rest server: do not use pbs_api_types::Authid Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 12/15] rest server: cleanup auth-log handling Dietmar Maurer
2021-09-20 10:37 ` Fabian Grünbichler
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 13/15] move src/server/rest.rs to pbs-server crate Dietmar Maurer
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 14/15] move proxmox_restore_daemon code into extra crate Dietmar Maurer
2021-09-20 12:01 ` Fabian Grünbichler
2021-09-20 9:13 ` [pbs-devel] [PATCH proxmox-backup rebase 15/15] basically a (semantic) revert of commit 991be99c37c6f55f43a3d9a2c54edb2a8dc6d4f2 "buildsys: workaround linkage issues from openid/curl build server stuff separate" Dietmar Maurer
2021-09-20 12:03 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1632134258.i0mkw8z4ep.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox