From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pbs-devel] [PATCH 0/4] Improve corrupt chunk handling
Date: Thu, 3 Sep 2020 17:51:23 +0200 (CEST) [thread overview]
Message-ID: <1629119323.707.1599148283648@webmail.proxmox.com> (raw)
In-Reply-To: <711517342.706.1599147653676@webmail.proxmox.com>
> On 09/03/2020 5:40 PM Dietmar Maurer <dietmar@proxmox.com> wrote:
>
>
> > Verify will now rename chunks it detects as corrupted, so future backups will be
> > forced to write them. The next GC will then clean these ".bad" files up, since
> > it has to scan each chunk directory anyway.
>
> That sounds quite dangerous to me. What about transient storage errors?
Maybe I miss-read your path. When do you remove those .bad files exactly? Only when
the client uploaded a good chunk already?
next prev parent reply other threads:[~2020-09-03 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:17 Stefan Reiter
2020-09-03 14:17 ` [pbs-devel] [PATCH proxmox-backup 1/4] verify: fix log units Stefan Reiter
2020-09-03 14:17 ` [pbs-devel] [PATCH proxmox-backup 2/4] verify: rename corrupted chunks with .bad extension Stefan Reiter
2020-09-03 14:17 ` [pbs-devel] [PATCH proxmox-backup 3/4] gc: remove .bad files on garbage collect Stefan Reiter
2020-09-04 12:20 ` Thomas Lamprecht
2020-09-03 14:17 ` [pbs-devel] [PATCH proxmox-backup 4/4] backup: check all referenced chunks actually exist Stefan Reiter
2020-09-03 15:40 ` [pbs-devel] [PATCH 0/4] Improve corrupt chunk handling Dietmar Maurer
2020-09-03 15:51 ` Dietmar Maurer [this message]
2020-09-07 9:31 ` Stefan Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629119323.707.1599148283648@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox