Re: [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation

Re: [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation

[Dietmar Maurer]

> On 07/22/2021 4:35 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>  
> that does not make sense, 

make sense to me,

> since re-using an existing one leads to an
> error.

because it really helps to see what already exists

Re: [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation

[Fabian Grünbichler]

On July 22, 2021 5:46 pm, Dietmar Maurer wrote:
>> On 07/22/2021 4:35 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
>> 
>>  
>> that does not make sense, 
> 
> make sense to me,

ack, maybe that was a bit strongly worded ;)

>> since re-using an existing one leads to an
>> error.
> 
> because it really helps to see what already exists
> 

we don't have that semantic for other completions though, and for sync 
jobs most users will have auto-generated names if they created their 
jobs with the GUI.. creating a datastore does not complete existing 
names, updating/showing/removing/using does. creating a new remote does 
not complete existing remote names, updating/showing/removing/using one 
does. same for users, API tokens - the only other exception that 
completes on creation is adding a new network interface.

but I don't have strong feelings about this (I literally stumbled upon 
this when doing the other patches) - other than that we should  be 
consistent. so if we agree that we want to complete existing identifiers 
when adding new entities, I'd send a separate series adding that to the 
others where it's missing.

[pbs-devel] [PATCH proxmox-backup 0/7] pull/sync group filter

[Fabian Grünbichler]

this has been requested a few times on the forum, e.g. for a special
sync job for the most important groups, or seeding of a new datastore
with a partial view of an existing one.

while it's possible to achieve similar results with hacky workarounds
based on group ownership and reduced "visibility", implementing it
properly is not that complex.

possible future additions in a similar fashion:
- only sync/pull encrypted snapshots (less trusted off-site location)
- only sync/pull latest snapshot in each group (fast seeding of new
  datastore)

Fabian Grünbichler (7):
  api-types: add schema for backup group
  pull: allow pulling groups selectively
  sync: add group filtering
  remote: add backup group scanning
  manager: extend sync/pull completion
  manager: render group filter properly
  manager: don't complete sync job ID on creation

 pbs-api-types/src/lib.rs               |   4 +
 src/api2/config/remote.rs              |  69 +++++++++++++++-
 src/api2/config/sync.rs                |  22 ++++++
 src/api2/pull.rs                       |  36 ++++++++-
 src/bin/proxmox-backup-manager.rs      | 105 ++++++++++++++++++++++---
 src/bin/proxmox_backup_manager/sync.rs |  22 +++++-
 src/config/sync.rs                     |  10 +++
 src/server/pull.rs                     |  24 +++++-
 www/config/SyncView.js                 |  13 ++-
 www/window/SyncJobEdit.js              |  12 +++
 10 files changed, 295 insertions(+), 22 deletions(-)

-- 
2.30.2

[pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation

[Fabian Grünbichler]

that does not make sense, since re-using an existing one leads to an
error.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 src/bin/proxmox_backup_manager/sync.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/bin/proxmox_backup_manager/sync.rs b/src/bin/proxmox_backup_manager/sync.rs
index a2c36854..37eb8ba5 100644
--- a/src/bin/proxmox_backup_manager/sync.rs
+++ b/src/bin/proxmox_backup_manager/sync.rs
@@ -101,7 +101,6 @@ pub fn sync_job_commands() -> CommandLineInterface {
         .insert("create",
                 CliCommand::new(&api2::config::sync::API_METHOD_CREATE_SYNC_JOB)
                 .arg_param(&["id"])
-                .completion_cb("id", config::sync::complete_sync_job_id)
                 .completion_cb("schedule", config::datastore::complete_calendar_event)
                 .completion_cb("store", config::datastore::complete_datastore_name)
                 .completion_cb("remote", config::remote::complete_remote_name)
-- 
2.30.2