From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation
Date: Fri, 23 Jul 2021 08:17:17 +0200 [thread overview]
Message-ID: <1627020655.mumlv0buee.astroid@nora.none> (raw)
In-Reply-To: <1240918108.626.1626968790003@webmail.proxmox.com>
On July 22, 2021 5:46 pm, Dietmar Maurer wrote:
>> On 07/22/2021 4:35 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
>>
>>
>> that does not make sense,
>
> make sense to me,
ack, maybe that was a bit strongly worded ;)
>> since re-using an existing one leads to an
>> error.
>
> because it really helps to see what already exists
>
we don't have that semantic for other completions though, and for sync
jobs most users will have auto-generated names if they created their
jobs with the GUI.. creating a datastore does not complete existing
names, updating/showing/removing/using does. creating a new remote does
not complete existing remote names, updating/showing/removing/using one
does. same for users, API tokens - the only other exception that
completes on creation is adding a new network interface.
but I don't have strong feelings about this (I literally stumbled upon
this when doing the other patches) - other than that we should be
consistent. so if we agree that we want to complete existing identifiers
when adding new entities, I'd send a separate series adding that to the
others where it's missing.
next prev parent reply other threads:[~2021-07-23 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:46 Dietmar Maurer
2021-07-23 6:17 ` Fabian Grünbichler [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-22 14:35 [pbs-devel] [PATCH proxmox-backup 0/7] pull/sync group filter Fabian Grünbichler
2021-07-22 14:35 ` [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627020655.mumlv0buee.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox