From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH 0/5] Add LVM (thin) support for single file restore
Date: Fri, 02 Jul 2021 14:39:58 +0200 [thread overview]
Message-ID: <1625229020.brdiyhyox3.astroid@nora.none> (raw)
In-Reply-To: <20210630155759.1894155-1-s.reiter@proxmox.com>
Reviewed-By: Fabian Grünbichler <f.gruenbichler@proxmox.com>
requires a Breaks on the old restore image (else the restore daemon
crashes because of missing lock/LVM support).
some potential for follow-ups/issues I encountered with a not-so-fast
PBS instance and bigger VMs:
- increase VM start timeout (currently 12s?), as the initial scan of
disks seems to block responding to the startup status request, and
scanning all VGs/LVs can take quite a lot longer than that -
alternatively, fix this blockage and/or consider VM started sooner?
- filter out "known unreadable" LVs, like Ceph (bluestore) OSDs
- investigate '--sysinit' option for lvchange/vgchange (seems
appropriate for what we are doing inside the VM ;))
- investigate '-K' to allow looking at "non-auto-activatable" LVs
and as discussed off-list, I think we should switch to
build-dependencies and copying binaries+needed libs in
build-initramfs.sh instead of downloading .deb packages and extracting
them only to remove part of their contents again - but that is firmly in
"improve/cleanup build" territory, so lower priority than the above.
On June 30, 2021 5:57 pm, Stefan Reiter wrote:
> Uses LVM tools to support LVM(-thin) volumes in the single-file restore daemon.
> Tested with multi-disk LVs, thinpools and different filesystems on top of them.
>
> Note for testing: The current proxmox-backup git master will not work for
> building the proxmox-restore-daemon binary, as the OpenID changes pull in some
> library dependencies not available in the restore VM.
>
>
> proxmox-backup-restore-image: Stefan Reiter (1):
> add LVM (thin) tooling
>
> src/build_initramfs.sh | 6 ++++++
> src/config-base | 1 +
> 2 files changed, 7 insertions(+)
>
> proxmox-backup: Stefan Reiter (4):
> file-restore-daemon/disk: dedup BucketComponents and make size
> optional
> file-restore-daemon/disk: fix component path errors
> file-restore-daemon/disk: ignore already-mounted error and prefix
> zpool
> file-restore-daemon/disk: add LVM (thin) support
>
> src/bin/proxmox_restore_daemon/api.rs | 2 +-
> src/bin/proxmox_restore_daemon/disk.rs | 222 +++++++++++++++++++++++--
> 2 files changed, 208 insertions(+), 16 deletions(-)
>
> --
> 2.30.2
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
next prev parent reply other threads:[~2021-07-02 12:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 15:57 Stefan Reiter
2021-06-30 15:57 ` [pbs-devel] [PATCH proxmox-backup-restore-image 1/5] add LVM (thin) tooling Stefan Reiter
2021-06-30 15:57 ` [pbs-devel] [PATCH proxmox-backup 2/5] file-restore-daemon/disk: dedup BucketComponents and make size optional Stefan Reiter
2021-06-30 15:57 ` [pbs-devel] [PATCH proxmox-backup 3/5] file-restore-daemon/disk: fix component path errors Stefan Reiter
2021-06-30 15:57 ` [pbs-devel] [PATCH proxmox-backup 4/5] file-restore-daemon/disk: ignore already-mounted error and prefix zpool Stefan Reiter
2021-06-30 15:57 ` [pbs-devel] [PATCH proxmox-backup 5/5] file-restore-daemon/disk: add LVM (thin) support Stefan Reiter
2021-07-02 12:39 ` Fabian Grünbichler [this message]
2021-07-05 6:26 ` [pbs-devel] [PATCH 0/5] Add LVM (thin) support for single file restore Thomas Lamprecht
2021-07-05 7:18 ` Fabian Grünbichler
2021-07-05 6:12 ` [pbs-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625229020.brdiyhyox3.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox