From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time
Date: Fri, 04 Jun 2021 10:21:17 +0200 [thread overview]
Message-ID: <1622794517.ypqwqri9n2.astroid@nora.none> (raw)
In-Reply-To: <20210604071625.4811-1-d.csapak@proxmox.com>
On June 4, 2021 9:16 am, Dominik Csapak wrote:
> we skip snapshots that are older than the last sync-time,
> log that so the user can know why it is not synced
well, technically last sync is a bit of a misnomer here anyway, since it
could also just be last backup made directly to the target datastore. we
might want to make this behaviour more explicit as well? or allow
marking groups/datastore as "sync target" to prevent manual backups from
interfering with syncs?
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/client/pull.rs | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/client/pull.rs b/src/client/pull.rs
> index 95720973..96414a7a 100644
> --- a/src/client/pull.rs
> +++ b/src/client/pull.rs
> @@ -14,6 +14,7 @@ use crate::{
> backup::*,
> client::*,
> server::WorkerTask,
> + task_log,
> tools::{compute_file_csum, ParallelHandler},
> };
> use proxmox::api::error::{HttpError, StatusCode};
> @@ -495,6 +496,11 @@ pub async fn pull_group(
>
> if let Some(last_sync_time) = last_sync {
> if last_sync_time > backup_time {
> + task_log!(
> + worker,
> + "skipping snapshot {} - older than last sync",
> + snapshot
> + );
adding this would mean that sync logs would grow and grow and grow over
time..
maybe a single:
skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) older than newest local snapshot.
it would mean only adding a single line to the output, but contains
almost all the information?
> continue;
> }
> }
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
next prev parent reply other threads:[~2021-06-04 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 7:16 Dominik Csapak
2021-06-04 8:21 ` Fabian Grünbichler [this message]
2021-06-04 9:03 ` Dietmar Maurer
2021-06-04 9:04 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622794517.ypqwqri9n2.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox