public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox 0/2] remove unnecessary websocket code
Date: Tue, 18 May 2021 10:33:31 +0200	[thread overview]
Message-ID: <1621326804.8t97fy5sgr.astroid@nora.none> (raw)
In-Reply-To: <20210517131101.23490-1-d.csapak@proxmox.com>

On May 17, 2021 3:10 pm, Dominik Csapak wrote:
> similar reasoning as for pve[0] but here we only have to consider
> xtermjs
> 
> same rules for compat/client code applies, if we apply for 1.x we
> can drop the client protocol in 2.0 and compat in 3.0
> else the client code in 3.0 and compat code in 4.0
> 
> we only have to make sure that we do that in lockstep with pve/pmg,
> since they share pve-xtermjs
> 
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-May/048216.html
> 
> Dominik Csapak (2):
>   proxmox-http/websocket: remove code for 'text' frames
>   proxmox-http/websocket: remove subprotocol handling
> 
>  proxmox-http/src/websocket/mod.rs | 39 ++++++++++++-------------------
>  1 file changed, 15 insertions(+), 24 deletions(-)
> 
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 




      parent reply	other threads:[~2021-05-18  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 13:10 [pbs-devel] " Dominik Csapak
2021-05-17 13:11 ` [pbs-devel] [PATCH proxmox 1/2] proxmox-http/websocket: remove code for 'text' frames Dominik Csapak
2021-05-17 13:11 ` [pbs-devel] [PATCH proxmox 2/2] proxmox-http/websocket: remove subprotocol handling Dominik Csapak
2021-05-18  8:33 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621326804.8t97fy5sgr.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal