From: Lukas Wagner <l.wagner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix refresh after TFA unlock
Date: Tue, 27 Jun 2023 13:30:16 +0200 [thread overview]
Message-ID: <157d1a1c-2054-38d2-f860-cffa8ac4f984@proxmox.com> (raw)
In-Reply-To: <aa1d24fb-a8d5-d753-0d7d-409b15b404e4@proxmox.com>
On 6/27/23 13:29, Dominik Csapak wrote:
> while it does work, the correct way to fix this is to add the column dataindex
> to the model definition, since that is what the diffstore uses to update it's
> data on a load
>
> i sent a fix for that, which is intended to be applied instead of this patch:
>
Ahh, that makes a whole lot more sense.
Thanks for the fixup!
--
- Lukas
next prev parent reply other threads:[~2023-06-27 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 10:04 [pbs-devel] [PATCH proxmox-backup 1/2] ui: add missing unlockTfa handler Lukas Wagner
2023-06-27 10:04 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix refresh after TFA unlock Lukas Wagner
2023-06-27 11:29 ` Dominik Csapak
2023-06-27 11:30 ` Lukas Wagner [this message]
2023-06-27 11:28 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: add missing unlockTfa handler Dominik Csapak
2023-06-27 11:32 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157d1a1c-2054-38d2-f860-cffa8ac4f984@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox