From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup 1/2] save last verify result in snapshot manifest
Date: Wed, 26 Aug 2020 06:30:06 +0200 (CEST) [thread overview]
Message-ID: <156308177.80.1598416207112@webmail.proxmox.com> (raw)
In-Reply-To: <20200825153028.22466-1-t.lamprecht@proxmox.com>
> On 08/25/2020 5:30 PM Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
>
>
> Save the state ("ok" or "failed") and the UPID of the respective
> verify task. With this we can easily allow to open the relevant task
> log and show when the last verify happened.
>
> As we already load the manifest when listing the snapshots, just add
> it there directly.
>
> We need to make the verify API call protected to be able to save the manifest.
Why? IMHO this should not be necessary, because backups are written by the 'backup' user.
next prev parent reply other threads:[~2020-08-26 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:30 Thomas Lamprecht
2020-08-25 15:30 ` [pbs-devel] [PATCH backup 2/2] ui: datastore content: show last verify result from a snapshot Thomas Lamprecht
2020-08-26 4:30 ` Dietmar Maurer [this message]
2020-08-26 6:15 ` [pbs-devel] [PATCH backup 1/2] save last verify result in snapshot manifest Thomas Lamprecht
2020-08-26 5:37 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156308177.80.1598416207112@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox