From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 00/14] various clippy fixes
Date: Sun, 18 Apr 2021 16:26:26 +0200 (CEST) [thread overview]
Message-ID: <1524469767.3672.1618755986380@webmail.proxmox.com> (raw)
Some of those changes may make sense, but it is really
a PITA to review them. Every change can break the code an introduce new
errors (which already happened in the past).
On the other side, It is hard to see any advantages for
most of those changes.
next reply other threads:[~2021-04-18 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 14:26 Dietmar Maurer [this message]
2021-04-19 6:59 ` Dominik Csapak
-- strict thread matches above, loose matches on Subject: below --
2021-04-16 10:28 Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524469767.3672.1618755986380@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox