From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] unbreak get_subscription without sshd installed
Date: Tue, 10 Nov 2020 17:01:31 +0100 (CET) [thread overview]
Message-ID: <1457363642.1045.1605024092426@webmail.proxmox.com> (raw)
In-Reply-To: <20201110155927.2650445-1-f.gruenbichler@proxmox.com>
Or make sure sshd is installed?
> On 11/10/2020 4:59 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
>
>
> which might be the case e.g. in a PBS container
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> we might want to switch to a different file as base? or even generate a file
> just for the server ID derivation?
>
> src/api2/node/subscription.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/api2/node/subscription.rs b/src/api2/node/subscription.rs
> index 67797fd5..010a0209 100644
> --- a/src/api2/node/subscription.rs
> +++ b/src/api2/node/subscription.rs
> @@ -94,7 +94,7 @@ pub fn get_subscription(
> Ok(None) => SubscriptionInfo {
> status: SubscriptionStatus::NOTFOUND,
> message: Some("There is no subscription key".into()),
> - serverid: Some(tools::get_hardware_address()?),
> + serverid: tools::get_hardware_address().ok(),
> url: Some(url.into()),
> ..Default::default()
> },
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2020-11-10 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:59 Fabian Grünbichler
2020-11-10 16:01 ` Dietmar Maurer [this message]
2020-11-10 16:52 ` Fabian Grünbichler
2020-11-10 16:54 ` Thomas Lamprecht
2020-11-10 17:23 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457363642.1045.1605024092426@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox