From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] proxmox-tape: api: restore_key-code moved to tape-encryption-keys
Date: Thu, 14 Apr 2022 09:50:21 +0200 [thread overview]
Message-ID: <1424ba39-b244-f0ca-fc51-fb0048892a8c@proxmox.com> (raw)
In-Reply-To: <20220413093005.61074-1-m.frank@proxmox.com>
On 13.04.22 11:30, Markus Frank wrote:
> The restore_key api-endpoint is tape/drive/{drive}/restore-key.
> Since I cannot set the url parameter for the drivename to null or
> undefined, when restoring by exported-key, I moved the
> added restore_key-api-code to
> "create_key aka POST api2/json/config/tape-encryption-keys" and
> added an ApiHandler call in the cli's "restore_key" to call
> "create_key" in the api.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> src/api2/config/tape_encryption_keys.rs | 39 ++++++++++++++++---
> src/api2/tape/drive.rs | 51 +++++++------------------
> src/bin/proxmox_tape/encryption_key.rs | 19 ++++++---
> 3 files changed, 61 insertions(+), 48 deletions(-)
>
>
applied, thanks!
Fixed the falsely required KDF param if a key was passed in a followup, together with some
cleanups.
prev parent reply other threads:[~2022-04-14 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:30 [pbs-devel] " Markus Frank
2022-04-13 9:30 ` [pbs-devel] [PATCH proxmox-backup] ui: proxmox-tape key restore Markus Frank
2022-04-14 7:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424ba39-b244-f0ca-fc51-fb0048892a8c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox