From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api: config: use guard for unmounting on failed datastore creation
Date: Thu, 20 Mar 2025 16:34:45 +0100 (CET) [thread overview]
Message-ID: <1345010253.943.1742484885722@webmail.proxmox.com> (raw)
In-Reply-To: <20250320121125.114333-1-h.laimer@proxmox.com>
> On 20.03.2025 13:11 CET Hannes Laimer <h.laimer@proxmox.com> wrote:
>
>
> Currently if any `?`/`bail!` happens between mounting and completing
> the creation process unmounting will be skipped. Adding this guard
> solves that problem and makes it easier to add things in the future
> without having to worry about a disk not being unmounted in case of a
> failed creation.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> Reported-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
Thanks, this patch will come in handy here [0].
Tested creating new datastore on ext3 -> fails
Tested reusing pre-existing datastore with corrupt folder structure -> fails
Tested moving and replacing the datastore config while datastore creattion, so that writing the config will fail by `mv datastore.cfg datastore.cfg.old && mkdir datastore.cfg` -> fails
For all 3 cases the removable datastore backing device is correctly unmounted after failure.
Therefore please consider this:
Tested-by: Christian Ebner <c.ebner@proxmox.com>
[0] https://lore.proxmox.com/pbs-devel/20250320131711.312894-6-c.ebner@proxmox.com/
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-20 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 12:11 Hannes Laimer
2025-03-20 15:34 ` Christian Ebner [this message]
2025-03-20 17:46 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345010253.943.1742484885722@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal