From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] tape: changer: sg_pt: query element types separately
Date: Mon, 12 Jul 2021 18:20:21 +0200 [thread overview]
Message-ID: <12b79b42-a8d9-1ace-b8f3-8f46f1bca9ef@proxmox.com> (raw)
In-Reply-To: <20210712154853.266573-1-dietmar@proxmox.com>
On 12.07.21 17:48, Dietmar Maurer wrote:
> From: Dominik Csapak <d.csapak@proxmox.com>
>
> Some changers do not like the DVCID bit when querying non-drives,
> this includes when querying 'all' elements.
>
> To circumvent this, we query each type by itself (like mtx does it),
> and only add the DVCID bit for drives (Data Transfer Elements).
>
> Reported by a user in the forum:
> https://forum.proxmox.com/threads/ibm-3584-ts3500-support.92291/
>
> and limit to 1000 elements per request.
> (Because some changers limit that request with the options we set)
>
> instead of checking if the data len was equal to the allocation_len
> for getting more data, we count the returned elements and compare
> that with the number we requested
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> ---
> src/tape/changer/sg_pt_changer.rs | 112 +++++++++++++++++++++---------
> 1 file changed, 80 insertions(+), 32 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-12 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:48 [pbs-devel] " Dietmar Maurer
2021-07-12 16:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b79b42-a8d9-1ace-b8f3-8f46f1bca9ef@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox