From: Christian Ebner <c.ebner@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup stable-2] pbs2to3: add upgrade checker binary
Date: Wed, 28 Jun 2023 11:43:35 +0200 (CEST) [thread overview]
Message-ID: <1291632408.2514.1687945415631@webmail.proxmox.com> (raw)
In-Reply-To: <d9b76624-42e2-22de-5586-f55480c417c5@proxmox.com>
Thanks for the review, I will send the v2 with comments taken into consideration.
Cheers,
Chris
> On 28.06.2023 10:59 CEST Fiona Ebner <f.ebner@proxmox.com> wrote:
>
>
> Am 28.06.23 um 10:10 schrieb Christian Ebner:
> > Adds the pbs2to3 upgrade checker with some basic checks.
> >
> > Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> Some things I noticed:
>
> > * chrony (Default in new Proxmox VE installations)
>
> Should be "Proxmox Backup Server installations"
>
> For repository checking, likely it's better to only check the suites of
> enabled repositories and only the 'deb' ones (not 'deb-src').
>
> My
> deb http://deb.debian.org/debian-debug bullseye-debug main contrib
> line produces:
> NOTICE: found unusual suite 'debug', neighter old 'bullseye' nor new
> 'bookworm'..
> but the suite is 'bullseye-debug'.
next prev parent reply other threads:[~2023-06-28 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 8:10 Christian Ebner
2023-06-28 8:59 ` Fiona Ebner
2023-06-28 9:43 ` Christian Ebner [this message]
2023-06-28 10:13 ` Lukas Wagner
2023-06-28 10:14 ` Lukas Wagner
2023-06-28 10:17 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291632408.2514.1687945415631@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox