From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] fix #2988: allow verification after finishing a snapshot
Date: Tue, 20 Oct 2020 08:12:30 +0200 (CEST) [thread overview]
Message-ID: <1274295978.147.1603174351148@webmail.proxmox.com> (raw)
In-Reply-To: <20201019144523.24840-3-s.reiter@proxmox.com>
> + let verify = |env: BackupEnvironment| {
> + // we are done, so we can safely drop the snapshot guard early
> + // to allow the verify task to acquire it for itself
Instead, I would keepä the lock and use/expose "verify_backup_dir_no_lock()". Is that
feasible?
> + std::mem::drop(_snap_guard);
> + if let Err(err) = env.verify_after_complete() {
> + env.log(format!(
> + "backup finished, but starting the requested verify task failed: {}",
> + err
> + ));
> + }
> + };
> +
> match (res, env.ensure_finished()) {
next prev parent reply other threads:[~2020-10-20 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 14:45 [pbs-devel] [PATCH proxmox-backup 1/3] fix missing block_in_place for remove_backup Stefan Reiter
2020-10-19 14:45 ` [pbs-devel] [PATCH proxmox-backup 2/3] datastore: cleanup open and load config only once Stefan Reiter
2020-10-20 5:54 ` [pbs-devel] applied: " Dietmar Maurer
2020-10-19 14:45 ` [pbs-devel] [PATCH proxmox-backup 3/3] fix #2988: allow verification after finishing a snapshot Stefan Reiter
2020-10-20 6:12 ` Dietmar Maurer [this message]
2020-10-20 7:10 ` Fabian Grünbichler
2020-10-20 5:53 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] fix missing block_in_place for remove_backup Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274295978.147.1603174351148@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox