public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	 Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] client/pull: log how many groups to pull were found
Date: Wed, 2 Dec 2020 07:25:29 +0100 (CET)	[thread overview]
Message-ID: <1214255675.462.1606890330472@webmail.proxmox.com> (raw)
In-Reply-To: <20201201140148.21622-1-d.csapak@proxmox.com>

applied

> On 12/01/2020 3:01 PM Dominik Csapak <d.csapak@proxmox.com> wrote:
> 
>  
> if no groups were found, the task log was very confusing as it
> contained no real information why nothing was synced, e.g.:
> 
>  Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
>  Sync datastore 'local-datastore' from 'remote/datastore'
>  sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
>  TASK OK
> 
> this patch simply logs how many groups were found and are about to be synced:
> 
>  Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
>  Sync datastore 'local-datastore' from 'remote/datastore'
>  found 0 groups to sync
>  sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
>  TASK OK
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/client/pull.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/client/pull.rs b/src/client/pull.rs
> index 5403d873..ed8256fa 100644
> --- a/src/client/pull.rs
> +++ b/src/client/pull.rs
> @@ -498,6 +498,8 @@ pub async fn pull_store(
>  
>      let mut list: Vec<GroupListItem> = serde_json::from_value(result["data"].take())?;
>  
> +    worker.log(format!("found {} groups to sync", list.len()));
> +
>      list.sort_unstable_by(|a, b| {
>          let type_order = a.backup_type.cmp(&b.backup_type);
>          if type_order == std::cmp::Ordering::Equal {
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




      reply	other threads:[~2020-12-02  6:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 14:01 [pbs-devel] " Dominik Csapak
2020-12-02  6:25 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214255675.462.1606890330472@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal